libcompat: Add a helper to get/set OS error state

On Unix like OSes, this saves/restores errno, on Windows both errno
and GetLastError state are saved/restored.

This should make it simpler to preserve that across function calls.

Additionally, while tracking down uses of GetLastError, some places
where the error code was printed out directly where replaced with
instances of w32_perror.

Signed-off-by: David Oberhollenzer <david.oberhollenzer@sigma-star.at>

1 files changed, 4 insertions, 4 deletions

diff --git a/lib/util/src/mkdir_p.c b/lib/util/src/mkdir_p.c
index 993d8ec..784e4ae 100644
--- a/lib/util/src/mkdir_p.c
+++ b/lib/util/src/mkdir_p.c
@@ -113,11 +113,11 @@ int mkdir_p(const char *path)
 		}
 
 		if (!CreateDirectoryW(wpath, NULL)) {
-			error = GetLastError();
+			os_error_t err = get_os_error_state();
+			set_os_error_state(err);
 
-			if (error != ERROR_ALREADY_EXISTS) {
-				fprintf(stderr, "Creating %s: %ld\n",
-					path, error);
+			if (err.w32_errno != ERROR_ALREADY_EXISTS) {
+				w32_perror(path);
 				goto fail;
 			}
 		}