diff options
| author | David Oberhollenzer <david.oberhollenzer@sigma-star.at> | 2023-03-04 21:28:14 +0100 |
|---|---|---|
| committer | David Oberhollenzer <david.oberhollenzer@sigma-star.at> | 2023-04-01 12:25:02 +0200 |
| commit | 32eb57dd9a19254565a0792ab9b627a3dac319f9 (patch) | |
| tree | c86314fda1e36f2231f352ec0f372aef7d3d9b0a /lib/sqfs/src/block_processor/backend.c | |
| parent | 6b1020ef3e034cbb6e0fa4cd984b181c0dd414ff (diff) | |
libsquashfs: remove the default block writer alignment feature
The idea of the block align feature was to allow micro-managing that
some files are forcefully aligned to 1k/4k ("device block") boundaries,
hoping to improve access time at the cost of data density. The feature
was not exposed in the tools for a long time and eventuall added to the
sort file. Measurement and experimentation showed, that it in fact
worsened the read performance on a test system with an old micro SD
card as the bottle neck.
The feature is removed, and if needed, can be brought back simply by
wrapping/sub-classing the default block writer, if need be..
Signed-off-by: David Oberhollenzer <david.oberhollenzer@sigma-star.at>
Diffstat (limited to 'lib/sqfs/src/block_processor/backend.c')
| -rw-r--r-- | lib/sqfs/src/block_processor/backend.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/lib/sqfs/src/block_processor/backend.c b/lib/sqfs/src/block_processor/backend.c index b443c9d..acff7f5 100644 --- a/lib/sqfs/src/block_processor/backend.c +++ b/lib/sqfs/src/block_processor/backend.c @@ -202,8 +202,7 @@ static int process_completed_fragment(sqfs_block_processor_t *proc, offset = 0; proc->frag_block = frag; proc->frag_block->index = index; - proc->frag_block->flags &= - (SQFS_BLK_DONT_COMPRESS | SQFS_BLK_ALIGN); + proc->frag_block->flags &= SQFS_BLK_DONT_COMPRESS; proc->frag_block->flags |= SQFS_BLK_FRAGMENT_BLOCK; } else { index = proc->frag_block->index; @@ -214,8 +213,7 @@ static int process_completed_fragment(sqfs_block_processor_t *proc, proc->frag_block->size += frag->size; proc->frag_block->flags |= - (frag->flags & - (SQFS_BLK_DONT_COMPRESS | SQFS_BLK_ALIGN)); + (frag->flags & SQFS_BLK_DONT_COMPRESS); } if (proc->frag_tbl != NULL) { |