diff options
| author | David Oberhollenzer <david.oberhollenzer@sigma-star.at> | 2023-03-04 21:28:14 +0100 |
|---|---|---|
| committer | David Oberhollenzer <david.oberhollenzer@sigma-star.at> | 2023-04-01 12:25:02 +0200 |
| commit | 32eb57dd9a19254565a0792ab9b627a3dac319f9 (patch) | |
| tree | c86314fda1e36f2231f352ec0f372aef7d3d9b0a /lib/common | |
| parent | 6b1020ef3e034cbb6e0fa4cd984b181c0dd414ff (diff) | |
libsquashfs: remove the default block writer alignment feature
The idea of the block align feature was to allow micro-managing that
some files are forcefully aligned to 1k/4k ("device block") boundaries,
hoping to improve access time at the cost of data density. The feature
was not exposed in the tools for a long time and eventuall added to the
sort file. Measurement and experimentation showed, that it in fact
worsened the read performance on a test system with an old micro SD
card as the bottle neck.
The feature is removed, and if needed, can be brought back simply by
wrapping/sub-classing the default block writer, if need be..
Signed-off-by: David Oberhollenzer <david.oberhollenzer@sigma-star.at>
Diffstat (limited to 'lib/common')
| -rw-r--r-- | lib/common/src/writer/init.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/lib/common/src/writer/init.c b/lib/common/src/writer/init.c index 497fc6e..fe5fcc5 100644 --- a/lib/common/src/writer/init.c +++ b/lib/common/src/writer/init.c @@ -120,8 +120,7 @@ int sqfs_writer_init(sqfs_writer_t *sqfs, const sqfs_writer_cfg_t *wrcfg) if (ret > 0) sqfs->super.flags |= SQFS_FLAG_COMPRESSOR_OPTIONS; - sqfs->blkwr = sqfs_block_writer_create(sqfs->outfile, - wrcfg->devblksize, 0); + sqfs->blkwr = sqfs_block_writer_create(sqfs->outfile, 0); if (sqfs->blkwr == NULL) { perror("creating block writer"); goto fail_uncmp; |