path: root/misc-utils
diff options
authorDavid Oberhollenzer <>2017-11-01 23:08:45 +0100
committerDavid Oberhollenzer <>2017-11-03 19:41:32 +0100
commit03dafe3202372e557f7125dc8155cb1d564d1f5e (patch)
tree5e289dc97ea58422161586391d1255e4175365d9 /misc-utils
parent0555cb2ea9bdc8e210e87e009154954a9bbc3a55 (diff)
Enable further warning flags, address new warnings
mtd_debug: Remove a duplicate if case. MTD_CAP_NANDFLASH has only one flag set (MTD_WRITEABLE). Directly below, we had a check for MTD_WRITEABLE in the else branch which can't possible ever have triggered. Checking for MTD_WRITEABLE in addition to the CAP constants was probably not intended anyway, given the check for the individual flags if all else fails. integck: We already established that "r" is less than the number of elements in the list, so the loop condition doesn't need to check if w is NULL in addition. At least this way, the compiler "gets" that w cannot be NULL below and doesn't issue warnings. Signed-off-by: David Oberhollenzer <>
Diffstat (limited to 'misc-utils')
1 files changed, 0 insertions, 2 deletions
diff --git a/misc-utils/mtd_debug.c b/misc-utils/mtd_debug.c
index 1fd6871..ac37e23 100644
--- a/misc-utils/mtd_debug.c
+++ b/misc-utils/mtd_debug.c
@@ -286,8 +286,6 @@ static int showinfo(int fd)
else if (mtd.flags == MTD_CAP_NANDFLASH)
- else if (mtd.flags == MTD_WRITEABLE)
- printf("MTD_WRITEABLE");
else {
int first = 1;
static struct {