aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorWolfram Sang <w.sang@pengutronix.de>2010-09-13 09:15:13 +0200
committerArtem Bityutskiy <Artem.Bityutskiy@nokia.com>2010-09-18 20:15:34 +0300
commitc9bdc0ca41b8ca9658d6ec7e22b2fd708a450b67 (patch)
tree13eaf83ecce1ae143364f697051631f13d90c58d
parent2c681d34611bf5b4a92efd51642ebd4723711679 (diff)
nanddump: rename --nobad to --noskipbadv1.4.0
"nobad" might lead to the assumption that bad blocks are skipped, but this option does exactly the opposite. Use a more descriptive name. Reported-by: Jon Povey <Jon.Povey@racelogic.co.uk> Signed-off-by: Wolfram Sang <w.sang@pengutronix.de> Cc: Mike Frysinger <vapier@gentoo.org> Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
-rw-r--r--nanddump.c10
1 files changed, 5 insertions, 5 deletions
diff --git a/nanddump.c b/nanddump.c
index 8b3d4a1..709b2db 100644
--- a/nanddump.c
+++ b/nanddump.c
@@ -50,7 +50,7 @@ static void display_help (void)
"-f file --file=file Dump to file\n"
"-l length --length=length Length\n"
"-n --noecc Read without error correction\n"
-"-N --nobad Read without bad block skipping\n"
+"-N --noskipbad Read without bad block skipping\n"
"-o --omitoob Omit oob data\n"
"-b --omitbad Omit bad blocks from the dump\n"
"-p --prettyprint Print nice (hexdump)\n"
@@ -77,7 +77,7 @@ static void display_version (void)
static bool pretty_print = false; // print nice
static bool noecc = false; // don't error correct
-static bool nobad = false; // don't skip bad blocks
+static bool noskipbad = false; // don't skip bad blocks
static bool omitoob = false; // omit oob data
static unsigned long start_addr; // start address
static unsigned long length; // dump length
@@ -107,7 +107,7 @@ static void process_options (int argc, char * const argv[])
{"startaddress", required_argument, 0, 's'},
{"length", required_argument, 0, 'l'},
{"noecc", no_argument, 0, 'n'},
- {"nobad", no_argument, 0, 'N'},
+ {"noskipbad", no_argument, 0, 'N'},
{"quiet", no_argument, 0, 'q'},
{0, 0, 0, 0},
};
@@ -162,7 +162,7 @@ static void process_options (int argc, char * const argv[])
noecc = true;
break;
case 'N':
- nobad = true;
+ noskipbad = true;
break;
case '?':
error++;
@@ -396,7 +396,7 @@ int main(int argc, char * const argv[])
for (ofs = start_addr; ofs < end_addr ; ofs+=bs) {
// new eraseblock , check for bad block
- if (nobad) {
+ if (noskipbad) {
badblock = 0;
} else if (blockstart != (ofs & (~meminfo.erasesize + 1))) {
blockstart = ofs & (~meminfo.erasesize + 1);