Change the signature of sqfs_compressor_create to return an error code

Make sure the function has a way of telling the caller *why* it failed.

This way, the function can convey whether it had an internal error, an
allocation failure, whether the arguments are totaly nonsensical, or
simply that the compressor *or specific configuration* is not supported.

Signed-off-by: David Oberhollenzer <david.oberhollenzer@sigma-star.at>

1 files changed, 5 insertions, 5 deletions

diff --git a/tar/sqfs2tar.c b/tar/sqfs2tar.c
index 2e4d0ef..2b013d6 100644
--- a/tar/sqfs2tar.c
+++ b/tar/sqfs2tar.c
@@ -556,15 +556,15 @@ int main(int argc, char **argv)
 				    super.block_size,
 				    SQFS_COMP_FLAG_UNCOMPRESS);
 
-	cmp = sqfs_compressor_create(&cfg);
+	ret = sqfs_compressor_create(&cfg, &cmp);
 
 #ifdef WITH_LZO
-	if (super.compression_id == SQFS_COMP_LZO && cmp == NULL)
-		cmp = lzo_compressor_create(&cfg);
+	if (super.compression_id == SQFS_COMP_LZO && ret != 0)
+		ret = lzo_compressor_create(&cfg, &cmp);
 #endif
 
-	if (cmp == NULL) {
-		fputs("Error creating compressor.\n", stderr);
+	if (ret != 0) {
+		sqfs_perror(filename, "creating compressor", ret);
 		goto out_fd;
 	}