aboutsummaryrefslogtreecommitdiff
path: root/lib/sqfs
diff options
context:
space:
mode:
authorDavid Oberhollenzer <david.oberhollenzer@sigma-star.at>2021-11-28 00:05:24 +0100
committerDavid Oberhollenzer <david.oberhollenzer@sigma-star.at>2021-12-05 10:29:36 +0100
commit2b8eb19a4de81db470f7ff5021a8a4822cc8c80d (patch)
treefe757fe44f96ccfbf49f7554ac2df3647490aea9 /lib/sqfs
parent4a4dbe027a082e546512b5ccb2999753651a9a28 (diff)
Fix: consistently use the widechar file API on Windows
When opening files on windows, use the widechar versions and convert from (assumed) UTF-8 to UTF-16 as needed. Since the broken, code-page-random API may acutall be intended in some use cases, leave that option in through an additional flag. Signed-off-by: David Oberhollenzer <david.oberhollenzer@sigma-star.at>
Diffstat (limited to 'lib/sqfs')
-rw-r--r--lib/sqfs/win32/io_file.c40
1 files changed, 36 insertions, 4 deletions
diff --git a/lib/sqfs/win32/io_file.c b/lib/sqfs/win32/io_file.c
index 7ff42b7..cfef296 100644
--- a/lib/sqfs/win32/io_file.c
+++ b/lib/sqfs/win32/io_file.c
@@ -155,14 +155,37 @@ sqfs_file_t *sqfs_open_file(const char *filename, sqfs_u32 flags)
sqfs_file_stdio_t *file;
LARGE_INTEGER size;
sqfs_file_t *base;
+ WCHAR *wpath = NULL;
+ DWORD length;
- if (flags & ~SQFS_FILE_OPEN_ALL_FLAGS)
+ if (flags & ~SQFS_FILE_OPEN_ALL_FLAGS) {
+ SetLastError(ERROR_INVALID_PARAMETER);
return NULL;
+ }
+
+ if (!(flags & SQFS_FILE_OPEN_NO_CHARSET_XFRM)) {
+ length = MultiByteToWideChar(CP_UTF8, 0, filename, -1, NULL, 0);
+ if (length <= 0)
+ return NULL;
+
+ wpath = calloc(sizeof(wpath[0]), length + 1);
+ if (wpath == NULL) {
+ SetLastError(ERROR_NOT_ENOUGH_MEMORY);
+ return NULL;
+ }
+
+ MultiByteToWideChar(CP_UTF8, 0, filename, -1,
+ wpath, length + 1);
+ wpath[length] = '\0';
+ }
file = calloc(1, sizeof(*file));
base = (sqfs_file_t *)file;
- if (file == NULL)
+ if (file == NULL) {
+ free(wpath);
+ SetLastError(ERROR_NOT_ENOUGH_MEMORY);
return NULL;
+ }
if (flags & SQFS_FILE_OPEN_READ_ONLY) {
file->readonly = true;
@@ -181,8 +204,17 @@ sqfs_file_t *sqfs_open_file(const char *filename, sqfs_u32 flags)
}
}
- file->fd = CreateFile(filename, access_flags, share_mode, NULL, creation_mode,
- FILE_ATTRIBUTE_NORMAL, NULL);
+ if (flags & SQFS_FILE_OPEN_NO_CHARSET_XFRM) {
+ file->fd = CreateFileA(filename, access_flags, share_mode, NULL,
+ creation_mode, FILE_ATTRIBUTE_NORMAL,
+ NULL);
+ } else {
+ file->fd = CreateFileW(wpath, access_flags, share_mode, NULL,
+ creation_mode, FILE_ATTRIBUTE_NORMAL,
+ NULL);
+ }
+
+ free(wpath);
if (file->fd == INVALID_HANDLE_VALUE) {
free(file);