Fix: xattr reader: read the header after seaking to an OOL value

If an xattr value is stored OOL, the value actually holds an 8 byte
reference to another, previously stored value. This reference points
to the header that we need to read to know the actual size of the
value before reading it, not the value itself, so after reading the
reference and seeking to it, the xattr reader needs to read the actual
header.

Signed-off-by: David Oberhollenzer <david.oberhollenzer@sigma-star.at>

1 files changed, 4 insertions, 0 deletions

diff --git a/lib/sqfs/xattr/xattr_reader.c b/lib/sqfs/xattr/xattr_reader.c
index 37f222a..d3adc46 100644
--- a/lib/sqfs/xattr/xattr_reader.c
+++ b/lib/sqfs/xattr/xattr_reader.c
@@ -256,6 +256,10 @@ int sqfs_xattr_reader_read_value(sqfs_xattr_reader_t *xr,
 		ret = sqfs_meta_reader_seek(xr->kvrd, new_start, new_offset);
 		if (ret)
 			return ret;
+
+		ret = sqfs_meta_reader_read(xr->kvrd, &value, sizeof(value));
+		if (ret)
+			return ret;
 	}
 
 	value.size = le32toh(value.size);