libfstree: add an assertion that root is not NULL

If the path argument is "", we assume that referes to root and set
the *existing* target node to the root node and skip ahead across
the tree search. This leaves "name" uninitialized, which makes
coverity panic, because fs->root could be NULL, going down the wrong
path.

Obviously, this should never, *ever* happen and there is no reasonable
recovery strategy if it suddenly does, so simply add an assertion.

Signed-off-by: David Oberhollenzer <david.oberhollenzer@sigma-star.at>

1 files changed, 2 insertions, 0 deletions

diff --git a/lib/fstree/add_by_path.c b/lib/fstree/add_by_path.c
index 8918efc..0afd898 100644
--- a/lib/fstree/add_by_path.c
+++ b/lib/fstree/add_by_path.c
@@ -9,6 +9,7 @@
 #include "fstree.h"
 
 #include <string.h>
+#include <assert.h>
 #include <errno.h>
 
 tree_node_t *fstree_add_generic(fstree_t *fs, const char *path,
@@ -19,6 +20,7 @@ tree_node_t *fstree_add_generic(fstree_t *fs, const char *path,
 
 	if (*path == '\0') {
 		child = fs->root;
+		assert(child != NULL);
 		goto out;
 	}