Move is_filename_sane to libfstree, add test cases

Signed-off-by: David Oberhollenzer <david.oberhollenzer@sigma-star.at>

2 files changed, 1 insertions, 78 deletions

diff --git a/lib/common/Makemodule.am b/lib/common/Makemodule.am
index e97085b..696a169 100644
--- a/lib/common/Makemodule.am
+++ b/lib/common/Makemodule.am
@@ -5,7 +5,7 @@ libcommon_a_SOURCES += lib/common/compress.c lib/common/comp_opt.c
 libcommon_a_SOURCES += lib/common/data_writer.c include/common.h
 libcommon_a_SOURCES += lib/common/get_path.c lib/common/io_stdin.c
 libcommon_a_SOURCES += lib/common/writer.c lib/common/perror.c
-libcommon_a_SOURCES += lib/common/mkdir_p.c lib/common/filename_sane.c
+libcommon_a_SOURCES += lib/common/mkdir_p.c
 libcommon_a_CFLAGS = $(AM_CFLAGS) $(LZO_CFLAGS)
 
 if WITH_LZO
diff --git a/lib/common/filename_sane.c b/lib/common/filename_sane.c
deleted file mode 100644
index 56f1127..0000000
--- a/lib/common/filename_sane.c
+++ /dev/null
@@ -1,77 +0,0 @@
-/* SPDX-License-Identifier: GPL-3.0-or-later */
-/*
- * filename_sane.c
- *
- * Copyright (C) 2019 David Oberhollenzer <goliath@infraroot.at>
- */
-#include "common.h"
-
-#include <string.h>
-
-#ifdef _WIN32
-#ifdef _MSC_VER
-#define strncasecmp _strnicmp
-#define strcasecmp _stricmp
-#endif
-
-static const char *bad_names[] = {
-	"CON", "PRN", "AUX", "NUL",
-	"COM1", "COM2", "COM3", "COM4", "COM5", "COM6", "COM7", "COM8", "COM9",
-	"LPT1", "LPT2", "LPT3", "LPT4", "LPT5", "LPT6", "LPT7", "LPT8", "LPT9",
-};
-
-static bool is_allowed_by_os(const char *name)
-{
-	size_t len, i;
-
-	for (i = 0; i < sizeof(bad_names) / sizeof(bad_names[0]); ++i) {
-		len = strlen(bad_names[i]);
-
-		if (strncasecmp(name, bad_names[i], len) != 0)
-			continue;
-
-		if (name[len] == '\0')
-			return false;
-
-		if (name[len] == '.' && strchr(name + len + 1, '.') == NULL)
-			return false;
-	}
-
-	return true;
-}
-#else
-static bool is_allowed_by_os(const char *name)
-{
-	(void)name;
-	return true;
-}
-#endif
-
-bool is_filename_sane(const char *name, bool check_os_specific)
-{
-	if (strcmp(name, ".") == 0 || strcmp(name, "..") == 0)
-		return false;
-
-	if (check_os_specific && !is_allowed_by_os(name))
-		return false;
-
-	while (*name != '\0') {
-		if (*name == '/' || *name == '\\')
-			return false;
-
-#ifdef _WIN32
-		if (check_os_specific) {
-			if (*name == '<' || *name == '>' || *name == ':')
-				return false;
-			if (*name == '"' || *name == '|' || *name == '?')
-				return false;
-			if (*name == '*' || *name <= 31)
-				return false;
-		}
-#endif
-
-		++name;
-	}
-
-	return true;
-}