Change the signature of sqfs_compressor_create to return an error code

Make sure the function has a way of telling the caller *why* it failed.

This way, the function can convey whether it had an internal error, an
allocation failure, whether the arguments are totaly nonsensical, or
simply that the compressor *or specific configuration* is not supported.

Signed-off-by: David Oberhollenzer <david.oberhollenzer@sigma-star.at>

1 files changed, 4 insertions, 4 deletions

diff --git a/extras/mk42sqfs.c b/extras/mk42sqfs.c
index e7c5357..92323e0 100644
--- a/extras/mk42sqfs.c
+++ b/extras/mk42sqfs.c
@@ -50,10 +50,10 @@ static sqfs_inode_generic_t *create_file_inode(sqfs_id_table_t *idtbl,
 int main(void)
 {
 	sqfs_meta_writer_t *inode_m, *dir_m;
+	int ret, status = EXIT_FAILURE;
 	sqfs_compressor_config_t cfg;
 	sqfs_inode_generic_t *inode;
 	unsigned int i, inode_num;
-	int status = EXIT_FAILURE;
 	sqfs_dir_writer_t *dirwr;
 	sqfs_compressor_t *cmp;
 	sqfs_id_table_t *idtbl;
@@ -88,9 +88,9 @@ int main(void)
 	sqfs_compressor_config_init(&cfg, super.compression_id,
 				    super.block_size, 0);
 
-	cmp = sqfs_compressor_create(&cfg);
-	if (cmp == NULL) {
-		fputs("Error creating compressor.\n", stderr);
+	ret = sqfs_compressor_create(&cfg, &cmp);
+	if (ret != 0) {
+		fprintf(stderr, "Error creating compressor: %d.\n", ret);
 		goto out_file;
 	}