summaryrefslogtreecommitdiff
path: root/difftool
diff options
context:
space:
mode:
authorDavid Oberhollenzer <david.oberhollenzer@sigma-star.at>2020-03-05 22:38:15 +0100
committerDavid Oberhollenzer <david.oberhollenzer@sigma-star.at>2020-03-05 22:41:04 +0100
commit85e36aab1258d8d9ec7b61ce013f167ef8e03ae0 (patch)
treeb1d59cce7894520b53c6b1fa86666d91587aaf82 /difftool
parent5acb22a6a7168f8b961777482f39a125158def50 (diff)
Change the signature of sqfs_compressor_create to return an error code
Make sure the function has a way of telling the caller *why* it failed. This way, the function can convey whether it had an internal error, an allocation failure, whether the arguments are totaly nonsensical, or simply that the compressor *or specific configuration* is not supported. Signed-off-by: David Oberhollenzer <david.oberhollenzer@sigma-star.at>
Diffstat (limited to 'difftool')
-rw-r--r--difftool/sqfsdiff.c10
1 files changed, 5 insertions, 5 deletions
diff --git a/difftool/sqfsdiff.c b/difftool/sqfsdiff.c
index c5d2bf2..6415165 100644
--- a/difftool/sqfsdiff.c
+++ b/difftool/sqfsdiff.c
@@ -39,15 +39,15 @@ static int open_sfqs(sqfs_state_t *state, const char *path)
state->super.block_size,
SQFS_COMP_FLAG_UNCOMPRESS);
- state->cmp = sqfs_compressor_create(&state->cfg);
+ ret = sqfs_compressor_create(&state->cfg, &state->cmp);
#ifdef WITH_LZO
- if (state->super.compression_id == SQFS_COMP_LZO && state->cmp == NULL)
- state->cmp = lzo_compressor_create(&state->cfg);
+ if (state->super.compression_id == SQFS_COMP_LZO && ret != 0)
+ ret = lzo_compressor_create(&state->cfg, &state->cmp);
#endif
- if (state->cmp == NULL) {
- fprintf(stderr, "%s: error creating compressor.\n", path);
+ if (ret != 0) {
+ sqfs_perror(path, "creating compressor", ret);
goto fail_file;
}