summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2011-04-22fs-tests: integck: refuse R/O file-systemArtem Bityutskiy
Refuse to test the file-system if it is mounted Read-only. Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
2011-04-22fs-tests: integck: free all allocated memory on exitArtem Bityutskiy
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
2011-04-22fs-tests: integck: assume that the parent is present in new_dirArtem Bityutskiy
We always pass non-NULL 'parent' argument to 'new_dir()', so no need to test it for NULL. Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
2011-04-22fs-tests: integck: lessen memory consumption even moreArtem Bityutskiy
This patch kills the "name" field from 'struct file_info' where we stored the original file name. We do not really need to keep this name around, becaus it might have long gone and it is not very interesting. Besides, we have several memory leaks where we leak 'file->name' strings, so this is the easiest way to fix those leaks as well. Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
2011-04-22fs-tests: integck: lessen memory consumptionArtem Bityutskiy
We do not need to store directory name in the 'struct dir_info' objects, because we already have it in 'struct dir_entry_info'. So we duplicate the names for directories in 'dir->name' and 'dir->entry->name'. Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
2011-04-22fs-tests: integck: clean up add_dir_entry usageArtem Bityutskiy
Make 'add_dir_entry()' consistent and allocate name for all types, not only for 'd' and 's'. Also, since 'add_dir_entry()' sets the parent - do not do this in the calling functions. This is a clean-up which makes 'add_dir_entry()' more consistent. Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
2011-04-22fs-tests: integck: remove symlinks memory leaksArtem Bityutskiy
When we create a symlink we also allocate a symlink_info structure and the target path name. But when we remove a symlink - we do not delete that memory. This patch fixes the issue. Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
2011-04-22fs-tests: integck: free raw write informationArtem Bityutskiy
The test leaks memory like hell because it does not free the raw writes information. This patch fixes the leaks. Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
2011-04-22fs-tests: integck: introduce free_writes_info helperArtem Bityutskiy
We have duplicated code for freeing write informatio - put it into a helper function. Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
2011-04-22fs-tests: integck: fix memory leak in dir_newArtem Bityutskiy
Do not initialize dir->name because add_dir_entry already does this for us, so we leak the memory. Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
2011-04-22fs-tests: integck: fix memory lead in dir_removeArtem Bityutskiy
When removing a directory and freeing corresponding 'dir_info' object - do not forget to free directory name as well. Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
2011-04-22fs-tests: integck: make file_truncate_file return errorArtem Bityutskiy
Teach 'file_truncate_file()' return an error to the caller if it fails to open the file or to truncate it. Additionally, check the error code from 'open()' in other places. Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
2011-04-22fs-tests: integck: make file_open return error on failureArtem Bityutskiy
Make 'file_open()' return an error to the caller if it fails to open the file. Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
2011-04-22fs-tests: integck: make operate_on_entry handle all errorsArtem Bityutskiy
Make 'operate_on_entry()' handle handle errors from all functions it calls and return the error code to the caller. Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
2011-04-22fs-tests: integck: teach file_unlink_file return an errorArtem Bityutskiy
Teach 'file_unlink_file()' return an error to the caller if the file cannot be unlinked. Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
2011-04-22fs-tests: integck: teach dir_remove return error and fix a memory leakArtem Bityutskiy
Teach 'dir_remove()' to return an error to the caller if it fails to remove the directory. Also, there was a memory leak - the 'path' string was not freed - fix it as well. Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
2011-04-22fs-tests: integck: teach symlink_remove return error on removal failureArtem Bityutskiy
When 'symlink_remove()' fails to unling a symlink - return an error to the calling function. Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
2011-04-22fs-tests: integck: make rename_entry return error on failureArtem Bityutskiy
Make 'rename_entry()' return an error to the caller when it fails to rename a directory entry. Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
2011-04-22fs-tests: integck: make operate_on_dir propagate errors upArtem Bityutskiy
Make 'operate_on_dir()' functions propogate errors up if any of the functions it calls failed. This patch also makes 'operate_on_entry()' return an error code, but without actual implementation. Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
2011-04-22fs-tests: integck: teach link_new to return error on creation failureArtem Bityutskiy
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
2011-04-22fs-tests: integck: teach symlink_new to return error on creation failureArtem Bityutskiy
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
2011-04-22fs-tests: integck: teach dir_new return error on creation failureArtem Bityutskiy
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
2011-04-22fs-tests: integck: make file_new return error on create failureArtem Bityutskiy
Teach 'file_new()' to return -1 if it fails to create a file. Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
2011-04-22fs-tests: integck: fix placeholders when printingArtem Bityutskiy
There is a lot of code where %u is used for printing off_t variables, which may be actually 64-bit wide. Fix this by using %llu. Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
2011-04-22fs-tests: integck: use unsigned int everywhereArtem Bityutskiy
The test sometimes uses "unsigned" and sometimes "unsigned int". This patch makes the code more consistent by making it use "unsigned int" everywhere. Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
2011-04-22fs-tests: integck: rename BUFFER_SIZEArtem Bityutskiy
Rename 'BUFFER_SIZE' constant into 'IO_BUFFER_SIZE' to reflect what is the buffer this constant is about. Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
2011-04-22fs-tests: integck: teach file_write_data return an errorArtem Bityutskiy
Make 'file_write_data()' return an error in case of failure. Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
2011-04-22fs-tests: integck: handle errors in file_mmap_writeArtem Bityutskiy
Teach 'file_mmap_write()' to propagate failures up to the caller. Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
2011-04-22fs-tests: integck: handle all failures in operate_on_open_fileArtem Bityutskiy
Make 'operate_on_open_file()' to handle possible 'fsync()' and 'fdatasync()' errors by returning -1 up to the caller. Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
2011-04-22fs-tests: integck: handle errors in file_deleteArtem Bityutskiy
Teach 'file_delete()' and several other functions it calls (like 'file_unlink()) to handle write errors and propagate the up to the caller. Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
2011-04-22fs-tests: integck: teach file_truncate return error codeArtem Bityutskiy
Teach 'file_truncate()' return an error code in case of failure. Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
2011-04-22fs-tests: integck: make more functions propogate error upArtem Bityutskiy
Teach 'operate_on_open_file()', 'operate_on_an_open_file()', and 'do_an_operation()' propogate errors up. Also move whole 'operate_on_file()' to a more logical place. Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
2011-04-22fs-tests: integck: handle errors when creating test dataArtem Bityutskiy
Make 'update_test_data()' and 'update_test_data()' check for errors and return error in case of failure. Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
2011-04-22fs-tests: integck: handle errors in remount_tested_fsArtem Bityutskiy
Teach 'remount_tested_fs()' return error code when it fails to mount the file-system. Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
2011-04-22fs-tests: integck: handle write failures in dir_newArtem Bityutskiy
Do not die in 'dir_new()' if it cannot create a new directory and this is not because of ENOSPC. Return NULL for all errors. Note, not all callers are ready to properly handle all errors so far. Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
2011-04-22fs-tests: integck: check deletion errors in rm_minus_rf_dirArtem Bityutskiy
Modify the 'rm_minus_rf_dir()' function to return -1 in case of any errors during deletions. Make 'integck()' handle the errors. Also introduce a 'pcv()' function to print error message if -v command line option was specified. Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
2011-04-22fs-tests: integck: introduce power cut testing argumentsArtem Bityutskiy
Introduce new command line arguments for power cut testing: -p to enable the power cut testing mode and -v to be verbose about the errors. The real functionality is not implemented so far. Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
2011-04-22serve_image: missing commaBrian Norris
Somebody didn't compile-test commit 9f4e6840. Artem: my fault, apologies. Signed-off-by: Brian Norris <computersforpeace@gmail.com> Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
2011-04-21serve_image: adjust classifier and type for printfAndy Shevchenko
The argument type of printf is __off64_t, meanwhile the classifier is "%ld". We agreed to use PRIu64 in such case. Signed-off-by: Andy Shevchenko <ext-andriy.shevchenko@nokia.com> Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
2011-04-21libmtd: use PRIu64 classifier for uint64_t printf argumentsAndy Shevchenko
Signed-off-by: Andy Shevchenko <ext-andriy.shevchenko@nokia.com> Acked-by: Mike Frysinger <vapier@gentoo.org> Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
2011-04-21mkfs.jffs2: fix casting of __off64_tAndy Shevchenko
The casting of __off64_t to unsigned long potentially wrong for values higher than ULONG_MAX. Let's fix that by using PRIu64 classifier. Signed-off-by: Andy Shevchenko <ext-andriy.shevchenko@nokia.com> Acked-by: Mike Frysinger <vapier@gentoo.org> Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
2011-04-18fs-tests: integck: do not expect max name length to be 256Artem Bityutskiy
The 'make_name()' function assumes that the maxumum file name length is 256 bytes, which is wrong. This patch fixes this. Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
2011-04-18fs-tests: integck: implement own version of CHECKArtem Bityutskiy
Remove the final dependency on the common code - the CHECK() macro. Now we are finally independent. The reason we needed this is that we are going to improve integck to handle errors more gracefully, in order to support failure testing better. And this requires changes in the common code, but it is ancient and shared by many tests, and we do not want to touch it. So we better make integck independent and concentrate on integck only. This patch also removes Makefile dependencies. And while on it, remove the broken 'tests' target. Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
2011-04-18fs-tests: integck: do not use tests_random_noArtem Bityutskiy
Do not use the shared 'tests_random_no()' function but use our own simple implementation instead. We do not need those rather complex and difficult to understand computations. Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
2011-04-18fs-tests: integck: do not use global common variablesArtem Bityutskiy
Do not use the 'tests_file_system_mount_dir' and 'tests_file_system_type' variables because we do not depend on them any longer. Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
2011-04-18fs-tests: integck: do not use tests_get_total_spaceArtem Bityutskiy
Do not use the common tests_get_total_space but extend our own get_free_space function and make it return both free and total amount of space. Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
2011-04-18fs-tests: integck: do not use tests_remountArtem Bityutskiy
Implement our own version of 'tests_remount()' instead of depending on the common implementation. Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
2011-04-18fs-tests: integck: do not use tests_fs_is_rootfsArtem Bityutskiy
Do not use the shared 'tests_fs_is_rootfs()' function - introduce 'fsinfo.is_rootfs' flag and utilize it instead. This is another step forward the goal to make integck independent of the common code. Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
2011-04-18fs-tests: integck: prefer to check for successArtem Bityutskiy
Many of standard C libraries return 0 on success and -1 on failure. Currently integck mostly checks for failure by comparing with -1, like: CHECK(fsync(fd) != -1) /* Don't die if not failure */ but in some places the check is like CHECK(fsync(fd) == 0) /* Don't die if success */ This patch harmonizes this an makes integck to use the second style which seems to be more logical. Besides, the binary is smaller in this case: [dedekind@eru fs-tests (master)]$ size integrity/integck-old text data bss dec hex filename 44677 1200 37408 83285 14555 integrity/integck [dedekind@eru fs-tests (master)]$ size integrity/integck-new text data bss dec hex filename 44661 1200 37408 83269 14545 integrity/integck Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
2011-04-18fs-tests: integck: do not use space after castArtem Bityutskiy
Since we are kernel people lets use the style we are accustomed to - no space between the cast and the variable: (type)a, not (type) a. Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-11-09 23:11:44 +0000