diff options
| author | Artem Bityutskiy <artem.bityutskiy@linux.intel.com> | 2014-09-08 15:05:54 +0300 |
|---|---|---|
| committer | Artem Bityutskiy <artem.bityutskiy@linux.intel.com> | 2014-09-16 18:11:50 +0300 |
| commit | 15685fe39f1665d53d8b316c8f837f20f8700d4b (patch) | |
| tree | 71ca17ccea7ade0cc1b9a441b7d4a0e8da768e5c /ubi-utils | |
| parent | 51b71fb46a069fa137c7a02769d60561e178ba15 (diff) | |
ubiformat: fix the subpage size hint on the error path
David Binderman <dcb314@hotmail.com> reports that the following piece of looks
wrong:
if (!args.subpage_size != mtd->min_io_size)
normsg("may be sub-page size is incorrect?");
I totally agree with him and I believe that we actually meant to have no
negation in fron to f 'args.subpage_size', so instead, the code should look
like this:
if (args.subpage_size != mtd->min_io_size)
normsg("may be sub-page size is incorrect?");
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Diffstat (limited to 'ubi-utils')
| -rw-r--r-- | ubi-utils/ubiformat.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/ubi-utils/ubiformat.c b/ubi-utils/ubiformat.c index 1b8f6fb..21409ca 100644 --- a/ubi-utils/ubiformat.c +++ b/ubi-utils/ubiformat.c @@ -633,9 +633,8 @@ static int format(libmtd_t libmtd, const struct mtd_dev_info *mtd, write_size, eb); if (errno != EIO) { - if (!args.subpage_size != mtd->min_io_size) - normsg("may be sub-page size is " - "incorrect?"); + if (args.subpage_size != mtd->min_io_size) + normsg("may be sub-page size is incorrect?"); goto out_free; } |