diff options
author | David Oberhollenzer <david.oberhollenzer@sigma-star.at> | 2016-08-25 13:41:50 +0200 |
---|---|---|
committer | David Oberhollenzer <david.oberhollenzer@sigma-star.at> | 2016-11-17 11:36:55 +0100 |
commit | f45bc6e3c99b62d04d50f210ed8d4f8d02b15357 (patch) | |
tree | 4251a99371b756dc55ba2e0c66a7c2ee139b4960 /include/libmtd.h | |
parent | 5841f15bf5d9cba2bdcc6526000538fedeee46e3 (diff) |
Remove unused and broken mtd_write_img function from libmtd
The function _tries_ to support short reads but doesn't adjust the
pointer into the buffer. If a short read happens, we scrambles the
flash contents. Interrupted reads aren't handled. Short or
interrupted writes aren't handled at all. Either a write succeeds
writing the entire buffer or the function gives up.
During an attempt at fixing it, it was discovered, that no mtd-utils
program uses this function. Furthermore, its highly specific nature
makes it more of a "feature looking for use case".
Signed-off-by: David Oberhollenzer <david.oberhollenzer@sigma-star.at>
Signed-off-by: Richard Weinberger <richard@nod.at>
Diffstat (limited to 'include/libmtd.h')
-rw-r--r-- | include/libmtd.h | 15 |
1 files changed, 0 insertions, 15 deletions
diff --git a/include/libmtd.h b/include/libmtd.h index a78c8cb..a6ff050 100644 --- a/include/libmtd.h +++ b/include/libmtd.h @@ -320,21 +320,6 @@ int mtd_write_oob(libmtd_t desc, const struct mtd_dev_info *mtd, int fd, uint64_t start, uint64_t length, void *data); /** - * mtd_write_img - write a file to MTD device. - * @mtd: MTD device description object - * @fd: MTD device node file descriptor - * @eb: eraseblock to write to - * @offs: offset withing the eraseblock to write to - * @img_name: the file to write - * - * This function writes an image @img_name the MTD device defined by @mtd. @eb - * and @offs are the starting eraseblock and offset on the MTD device. Returns - * %0 in case of success and %-1 in case of failure. - */ -int mtd_write_img(const struct mtd_dev_info *mtd, int fd, int eb, int offs, - const char *img_name); - -/** * mtd_probe_node - test MTD node. * @desc: MTD library descriptor * @node: the node to test |