diff options
| author | Daniel Wagner <daniel.wagner@siemens.com> | 2017-06-12 12:50:52 +0200 |
|---|---|---|
| committer | David Oberhollenzer <david.oberhollenzer@sigma-star.at> | 2017-06-14 10:55:27 +0200 |
| commit | b8e785a96f907022466bd383ec6afaa201e5f759 (patch) | |
| tree | 4c0e50db8217f013b1eb38f4311e44adf0d00fc8 | |
| parent | 12e27a1b2adf14c33694db82e1f6f8bde560b9a2 (diff) | |
nor-utils: Return error code if command line option is unknown
The tools in question will quit with an exit code 0 if the command
line option was not recognized. By returning an error code a calling
script has the possibility to distinguish between a real success and
an invalid invocation.
Signed-off-by: Daniel Wagner <daniel.wagner@siemens.com>
Signed-off-by: David Oberhollenzer <david.oberhollenzer@sigma-star.at>
| -rw-r--r-- | nor-utils/rfddump.c | 8 | ||||
| -rw-r--r-- | nor-utils/rfdformat.c | 8 |
2 files changed, 8 insertions, 8 deletions
diff --git a/nor-utils/rfddump.c b/nor-utils/rfddump.c index 048f58c..5141ea3 100644 --- a/nor-utils/rfddump.c +++ b/nor-utils/rfddump.c @@ -55,7 +55,7 @@ struct rfd { int verbose; }; -void display_help(void) +void display_help(int status) { printf("Usage: %s [OPTIONS] MTD-device filename\n" "Dumps the contents of a resident flash disk\n" @@ -65,7 +65,7 @@ void display_help(void) "-v --verbose Be verbose\n" "-b size --blocksize Block size (defaults to erase unit)\n", PROGRAM_NAME); - exit(0); + exit(status); } void display_version(void) @@ -101,7 +101,7 @@ void process_options(int argc, char *argv[], struct rfd *rfd) switch (c) { case 'h': - display_help(); + display_help(EXIT_SUCCESS); break; case 'V': display_version(); @@ -119,7 +119,7 @@ void process_options(int argc, char *argv[], struct rfd *rfd) } if ((argc - optind) != 2 || error) - display_help(); + display_help(EXIT_FAILURE); rfd->mtd_filename = argv[optind]; rfd->out_filename = argv[optind + 1]; diff --git a/nor-utils/rfdformat.c b/nor-utils/rfdformat.c index d393975..1f01a85 100644 --- a/nor-utils/rfdformat.c +++ b/nor-utils/rfdformat.c @@ -30,7 +30,7 @@ #include "common.h" -void display_help(void) +void display_help(int status) { printf("Usage: %s [OPTIONS] MTD-device\n" "Formats NOR flash for resident flash disk\n" @@ -38,7 +38,7 @@ void display_help(void) "-h --help display this help and exit\n" "-V --version output version information and exit\n", PROGRAM_NAME); - exit(0); + exit(status); } void display_version(void) @@ -69,7 +69,7 @@ void process_options(int argc, char *argv[], const char **mtd_filename) switch (c) { case 'h': - display_help(); + display_help(EXIT_SUCCESS); break; case 'V': display_version(); @@ -81,7 +81,7 @@ void process_options(int argc, char *argv[], const char **mtd_filename) } if ((argc - optind) != 1 || error) - display_help(); + display_help(EXIT_FAILURE); *mtd_filename = argv[optind]; } |