diff options
| author | David Oberhollenzer <david.oberhollenzer@sigma-star.at> | 2020-01-24 23:57:40 +0100 |
|---|---|---|
| committer | David Oberhollenzer <david.oberhollenzer@sigma-star.at> | 2020-02-09 22:13:18 +0100 |
| commit | 7d40c1a1420bc95af20624aa22e254a8eb3356f0 (patch) | |
| tree | 75a84128e11c709f8051a73fd37373754a4ede95 | |
| parent | 24b0e6277b36c46075e2e23896aa9ec43729efab (diff) | |
mtd-utils: Fix wrong argument to sizeof in nanddump
Some temporary buffers are allocated with "sizeof(pointer) * count" as
size argument, which cannot possibly be correct.
Assuming what was meant was "sizeof(pointer[0]) * count" makes sense
in the context of how the buffers are used, but is actually pretty
pointless, since the buffers are unsigend char.
Signed-off-by: David Oberhollenzer <david.oberhollenzer@sigma-star.at>
| -rw-r--r-- | nand-utils/nanddump.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/nand-utils/nanddump.c b/nand-utils/nanddump.c index 62699e0..d7fc320 100644 --- a/nand-utils/nanddump.c +++ b/nand-utils/nanddump.c @@ -362,8 +362,8 @@ int main(int argc, char * const argv[]) return errmsg("mtd_get_dev_info failed"); /* Allocate buffers */ - oobbuf = xmalloc(sizeof(oobbuf) * mtd.oob_size); - readbuf = xmalloc(sizeof(readbuf) * mtd.min_io_size); + oobbuf = xmalloc(mtd.oob_size); + readbuf = xmalloc(mtd.min_io_size); if (noecc) { if (ioctl(fd, MTDFILEMODE, MTD_FILE_MODE_RAW) != 0) { |