diff options
author | Andy Shevchenko <ext-andriy.shevchenko@nokia.com> | 2011-04-05 17:32:29 +0300 |
---|---|---|
committer | Artem Bityutskiy <Artem.Bityutskiy@nokia.com> | 2011-04-05 17:41:02 +0300 |
commit | a70811466de2c4c0c3a538e5e04a4dd1a8fbcc03 (patch) | |
tree | b82457da57879384ef276c5131bfae6b3d7cf92d | |
parent | 1bf8fb86ef192bc182a0c7cecdfc0792d6555fda (diff) |
tests: jittertest: fix set of compiler warnings
- time() was used without prototype.
- the return value of read() and write() wasn't checked
- classificator in printf() was wrong for argument of size_t type
Don't continue to read the /proc/profile in case when write was failed.
Signed-off-by: Andy Shevchenko <ext-andriy.shevchenko@nokia.com>
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
-rw-r--r-- | tests/jittertest/JitterTest.c | 13 |
1 files changed, 10 insertions, 3 deletions
diff --git a/tests/jittertest/JitterTest.c b/tests/jittertest/JitterTest.c index fcf8e0d..76371e8 100644 --- a/tests/jittertest/JitterTest.c +++ b/tests/jittertest/JitterTest.c @@ -82,6 +82,7 @@ #include <string.h> /* strcpy, strcmp */ #include <stdlib.h> /* exit, atol, atoi */ #include <sys/time.h> /* setitimer, settimeofday, gettimeofday */ +#include <time.h> /* time */ #include <signal.h> /* signal */ #include <sched.h> /* sched_setscheduler, sched_get_priority_min,*/ /* sched_get_priority_max */ @@ -475,7 +476,11 @@ void doGrabKProfile(int jitterusec, char *fileName) while((readBytes = read(fdProfile, readBuf, sizeof(readBuf))) > 0) { - write(fdSnapshot, readBuf, readBytes); + int writeBytes = write(fdSnapshot, readBuf, readBytes); + if (writeBytes != readBytes) { + perror("write error"); + break; + } } close(fdSnapshot); @@ -650,7 +655,9 @@ void AlarmHandler( if(DoRead) { - read(Fd2, tmpBuf, 1); + cntr = read(Fd2, tmpBuf, 1); + if (cntr < 0) + perror("read error"); lseek(Fd2, 0, SEEK_SET); /* back to start */ } @@ -1032,7 +1039,7 @@ int Write(int fd, void *buf, size_t bytes, int lineNo) if(err < bytes) { - printf("Write Error at line %i! Wanted to write %i bytes, but wrote only %i bytes.\n", + printf("Write Error at line %i! Wanted to write %zu bytes, but wrote only %i bytes.\n", lineNo, bytes, err); perror("Write did not complete. Error. Bye:"); /* show error from errno. */ exit(1); |