diff options
| author | Richard Genoud <richard.genoud@gmail.com> | 2012-09-12 16:37:19 +0200 |
|---|---|---|
| committer | Artem Bityutskiy <artem.bityutskiy@linux.intel.com> | 2012-09-25 17:04:09 +0300 |
| commit | 1d73b5ef185b10f44afb73b91c960c9e9e6d2bf6 (patch) | |
| tree | a5b9386d38613a04fc421150ab64a92201b8f628 | |
| parent | 3a8e8d14f0ecaf2362e0d12541087036a2a201dd (diff) | |
ubiformat: fix failure on big partitions (>4Gio)
The offset (which is 64bits when mtd-utils are not compile with
WITHOUT_LARGEFILE) is calculated like that:
offset = nb * size;
But nb and size are int, so on 32bits platforms, there's a possible
overflow.
So, it should be replace with:
offset = (off_t)nb * size;
If WITHOUT_LARGEFILE is defined, there still be an overflow, but it's
what we want, right ?
Cheney Chen tested an ubiformat on a NAND (5.9 GiB mtd part).
Reported-by: Cheney Chen <cheneychencl2012@gmail.com>
Tested-by: Cheney Chen <cheneychencl2012@gmail.com>
Signed-off-by: Richard Genoud <richard.genoud@gmail.com>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
| -rw-r--r-- | ubi-utils/libubigen.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/ubi-utils/libubigen.c b/ubi-utils/libubigen.c index 9eaa7f5..d2a949b 100644 --- a/ubi-utils/libubigen.c +++ b/ubi-utils/libubigen.c @@ -279,7 +279,7 @@ int ubigen_write_layout_vol(const struct ubigen_info *ui, int peb1, int peb2, memset(outbuf + ui->data_offs + ui->vtbl_size, 0xFF, ui->peb_size - ui->data_offs - ui->vtbl_size); - seek = peb1 * ui->peb_size; + seek = (off_t) peb1 * ui->peb_size; if (lseek(fd, seek, SEEK_SET) != seek) { sys_errmsg("cannot seek output file"); goto out_free; @@ -293,7 +293,7 @@ int ubigen_write_layout_vol(const struct ubigen_info *ui, int peb1, int peb2, goto out_free; } - seek = peb2 * ui->peb_size; + seek = (off_t) peb2 * ui->peb_size; if (lseek(fd, seek, SEEK_SET) != seek) { sys_errmsg("cannot seek output file"); goto out_free; |