diff options
author | Guido MartÃnez <guido@vanguardiasur.com.ar> | 2014-08-14 13:29:45 -0300 |
---|---|---|
committer | Artem Bityutskiy <artem.bityutskiy@linux.intel.com> | 2014-09-08 13:29:32 +0300 |
commit | ebf0d3d85910f485ebb64b3df2a6e2042a75c807 (patch) | |
tree | 8c88bc9189c78aaa769638c53942a3457876491d | |
parent | b7455d847ab4f9eeeb6a729efc306bfda7bddc99 (diff) |
nandtest: fix --reads argument
The --reads option specifies the argument as optional, but doesn't check
for a null optarg, which means that nandtest segfaults when run as
"nandtest --reads".
Fix this by making the argument required, and changing the help text to
not specify it as optional. Argument -r already specifies the argument
as required, so we fix this inconsistency too.
Signed-off-by: Guido MartÃnez <guido@vanguardiasur.com.ar>
Acked-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
-rw-r--r-- | nandtest.c | 4 |
1 files changed, 2 insertions, 2 deletions
@@ -24,7 +24,7 @@ void usage(int status) " -m, --markbad Mark blocks bad if they appear so\n" " -s, --seed Supply random seed\n" " -p, --passes Number of passes\n" - " -r, --reads Read & check iterations per pass (default=4)\n" + " -r <n>, --reads=<n> Read & check <n> times per pass\n" " -o, --offset Start offset on flash\n" " -l, --length Length of flash to test\n" " -k, --keep Restore existing contents after test\n", @@ -166,7 +166,7 @@ int main(int argc, char **argv) { "passes", required_argument, 0, 'p' }, { "offset", required_argument, 0, 'o' }, { "length", required_argument, 0, 'l' }, - { "reads", optional_argument, 0, 'r' }, + { "reads", required_argument, 0, 'r' }, { "keep", no_argument, 0, 'k' }, {0, 0, 0, 0}, }; |