From 8b5a2d64fa95cb964540b950ca237545d9e51822 Mon Sep 17 00:00:00 2001 From: David Oberhollenzer Date: Sat, 9 Sep 2023 00:06:08 +0200 Subject: libcommon: get rid of write_data_from_file Modify gensquashfs to pack data using an istream wrapper, similar to tar2sqfs. To implement the no-tail-pack option, we need the file size, so we simply open a raw handle first, and query it (using libsquashfs API) and then create the stream wrapper. For the output side, we create a block-processor ostream wrapper and splice it. Since gensquashfs is the only, remaining user of the pack-a-file functon, we can then remove it from libcommon. Signed-off-by: David Oberhollenzer --- lib/common/Makemodule.am | 3 +-- lib/common/src/data_writer.c | 54 -------------------------------------------- 2 files changed, 1 insertion(+), 56 deletions(-) delete mode 100644 lib/common/src/data_writer.c (limited to 'lib') diff --git a/lib/common/Makemodule.am b/lib/common/Makemodule.am index e0cc551..a50ddcb 100644 --- a/lib/common/Makemodule.am +++ b/lib/common/Makemodule.am @@ -1,8 +1,7 @@ libcommon_a_SOURCES = include/common.h include/simple_writer.h \ include/compress_cli.h \ lib/common/src/hardlink.c lib/common/src/print_version.c \ - lib/common/src/compress.c \ - lib/common/src/comp_opt.c lib/common/src/data_writer.c \ + lib/common/src/compress.c lib/common/src/comp_opt.c \ lib/common/src/parse_size.c lib/common/src/print_size.c \ lib/common/src/writer/init.c lib/common/src/writer/cleanup.c \ lib/common/src/writer/serialize_fstree.c lib/common/src/writer/finish.c\ diff --git a/lib/common/src/data_writer.c b/lib/common/src/data_writer.c deleted file mode 100644 index ceccaac..0000000 --- a/lib/common/src/data_writer.c +++ /dev/null @@ -1,54 +0,0 @@ -/* SPDX-License-Identifier: GPL-3.0-or-later */ -/* - * data_writer.c - * - * Copyright (C) 2019 David Oberhollenzer - */ -#include "common.h" - -static sqfs_u8 buffer[4096]; - -int write_data_from_file(const char *filename, sqfs_block_processor_t *data, - sqfs_inode_generic_t **inode, sqfs_file_t *file, - int flags) -{ - sqfs_u64 filesz, offset; - size_t diff; - int ret; - - ret = sqfs_block_processor_begin_file(data, inode, NULL, flags); - if (ret) { - sqfs_perror(filename, "beginning file data blocks", ret); - return -1; - } - - filesz = file->get_size(file); - - for (offset = 0; offset < filesz; offset += diff) { - if (filesz - offset > sizeof(buffer)) { - diff = sizeof(buffer); - } else { - diff = filesz - offset; - } - - ret = file->read_at(file, offset, buffer, diff); - if (ret) { - sqfs_perror(filename, "reading file range", ret); - return -1; - } - - ret = sqfs_block_processor_append(data, buffer, diff); - if (ret) { - sqfs_perror(filename, "packing file data", ret); - return -1; - } - } - - ret = sqfs_block_processor_end_file(data); - if (ret) { - sqfs_perror(filename, "finishing file data", ret); - return -1; - } - - return 0; -} -- cgit v1.2.3