From d07354def451e13c1757c871cd6213fba058dcc0 Mon Sep 17 00:00:00 2001 From: David Oberhollenzer Date: Sat, 27 Jul 2019 21:27:47 +0200 Subject: Fix free() of stack pointer in id_table_read error path We didn't allocate the ID table, so we don't need to free() it when reading from disk fails. Signed-off-by: David Oberhollenzer --- lib/sqfs/id_table_read.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) (limited to 'lib/sqfs') diff --git a/lib/sqfs/id_table_read.c b/lib/sqfs/id_table_read.c index bed0cf4..0110082 100644 --- a/lib/sqfs/id_table_read.c +++ b/lib/sqfs/id_table_read.c @@ -28,10 +28,8 @@ int id_table_read(id_table_t *tbl, int fd, sqfs_super_t *super, tbl->max_ids = super->id_count; tbl->ids = sqfs_read_table(fd, cmp, tbl->num_ids * sizeof(uint32_t), super->id_table_start); - if (tbl->ids == NULL) { - free(tbl); + if (tbl->ids == NULL) return -1; - } for (i = 0; i < tbl->num_ids; ++i) tbl->ids[i] = le32toh(tbl->ids[i]); -- cgit v1.2.3