From 7fb91aa5872a79ab94a9adae6ca72f1b1d0f8e36 Mon Sep 17 00:00:00 2001 From: David Oberhollenzer Date: Sun, 6 Oct 2019 19:25:12 +0200 Subject: Fix resource leaks reported by coverity Signed-off-by: David Oberhollenzer --- lib/sqfs/read_inode.c | 8 ++++++-- lib/sqfs/xattr_writer.c | 1 + 2 files changed, 7 insertions(+), 2 deletions(-) (limited to 'lib/sqfs') diff --git a/lib/sqfs/read_inode.c b/lib/sqfs/read_inode.c index f877da1..7e59445 100644 --- a/lib/sqfs/read_inode.c +++ b/lib/sqfs/read_inode.c @@ -263,8 +263,10 @@ static int read_inode_dir_ext(sqfs_meta_reader_t *ir, sqfs_inode_t *base, for (i = 0; i <= dir.inodex_count; ++i) { err = sqfs_meta_reader_read(ir, &ent, sizeof(ent)); - if (err) + if (err) { + free(out); return err; + } SWAB32(ent.start_block); SWAB32(ent.index); @@ -289,8 +291,10 @@ static int read_inode_dir_ext(sqfs_meta_reader_t *ir, sqfs_inode_t *base, err = sqfs_meta_reader_read(ir, out->extra + index_used, ent.size + 1); - if (err) + if (err) { + free(out); return err; + } } out->num_dir_idx_bytes = index_used; diff --git a/lib/sqfs/xattr_writer.c b/lib/sqfs/xattr_writer.c index 25fee80..22d4639 100644 --- a/lib/sqfs/xattr_writer.c +++ b/lib/sqfs/xattr_writer.c @@ -359,6 +359,7 @@ static sqfs_s32 write_value(sqfs_meta_writer_t *mw, const char *value_str, if (err) goto fail; + free(value); return sizeof(vent) + size; fail: free(value); -- cgit v1.2.3