From 162142b7930248d83a77e8d8f4eba5896d5b267a Mon Sep 17 00:00:00 2001 From: David Oberhollenzer Date: Sun, 24 Nov 2019 16:36:20 +0100 Subject: Cleanup libsquashfs invalid argument error codes - Add an explicit "you're holding it wrong" error code. - Consistently return error codes and not have some special places where -1 is returned. Signed-off-by: David Oberhollenzer --- lib/sqfs/comp/lzma.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'lib/sqfs/comp/lzma.c') diff --git a/lib/sqfs/comp/lzma.c b/lib/sqfs/comp/lzma.c index 002376f..f7ab428 100644 --- a/lib/sqfs/comp/lzma.c +++ b/lib/sqfs/comp/lzma.c @@ -48,7 +48,7 @@ static sqfs_s32 lzma_comp_block(sqfs_compressor_t *base, const sqfs_u8 *in, int ret; if (outsize < LZMA_HEADER_SIZE || size >= 0x7FFFFFFF) - return 0; + return SQFS_ERROR_ARG_INVALID; lzma_lzma_preset(&opt, LZMA_DEFAULT_LEVEL); opt.dict_size = lzma->block_size; @@ -93,7 +93,7 @@ static sqfs_s32 lzma_uncomp_block(sqfs_compressor_t *base, const sqfs_u8 *in, (void)base; if (size >= 0x7FFFFFFF) - return 0; + return SQFS_ERROR_ARG_INVALID; if (size < sizeof(lzma_header)) return SQFS_ERROR_CORRUPTED; -- cgit v1.2.3