From 85e36aab1258d8d9ec7b61ce013f167ef8e03ae0 Mon Sep 17 00:00:00 2001 From: David Oberhollenzer Date: Thu, 5 Mar 2020 22:38:15 +0100 Subject: Change the signature of sqfs_compressor_create to return an error code Make sure the function has a way of telling the caller *why* it failed. This way, the function can convey whether it had an internal error, an allocation failure, whether the arguments are totaly nonsensical, or simply that the compressor *or specific configuration* is not supported. Signed-off-by: David Oberhollenzer --- lib/sqfs/comp/internal.h | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) (limited to 'lib/sqfs/comp/internal.h') diff --git a/lib/sqfs/comp/internal.h b/lib/sqfs/comp/internal.h index 7518f56..0566683 100644 --- a/lib/sqfs/comp/internal.h +++ b/lib/sqfs/comp/internal.h @@ -24,18 +24,23 @@ SQFS_INTERNAL int sqfs_generic_read_options(sqfs_file_t *file, void *data, size_t size); SQFS_INTERNAL -sqfs_compressor_t *xz_compressor_create(const sqfs_compressor_config_t *cfg); +int xz_compressor_create(const sqfs_compressor_config_t *cfg, + sqfs_compressor_t **out); SQFS_INTERNAL -sqfs_compressor_t *gzip_compressor_create(const sqfs_compressor_config_t *cfg); +int gzip_compressor_create(const sqfs_compressor_config_t *cfg, + sqfs_compressor_t **out); SQFS_INTERNAL -sqfs_compressor_t *lz4_compressor_create(const sqfs_compressor_config_t *cfg); +int lz4_compressor_create(const sqfs_compressor_config_t *cfg, + sqfs_compressor_t **out); SQFS_INTERNAL -sqfs_compressor_t *zstd_compressor_create(const sqfs_compressor_config_t *cfg); +int zstd_compressor_create(const sqfs_compressor_config_t *cfg, + sqfs_compressor_t **out); SQFS_INTERNAL -sqfs_compressor_t *lzma_compressor_create(const sqfs_compressor_config_t *cfg); +int lzma_compressor_create(const sqfs_compressor_config_t *cfg, + sqfs_compressor_t **out); #endif /* INTERNAL_H */ -- cgit v1.2.3