From 32eb57dd9a19254565a0792ab9b627a3dac319f9 Mon Sep 17 00:00:00 2001 From: David Oberhollenzer Date: Sat, 4 Mar 2023 21:28:14 +0100 Subject: libsquashfs: remove the default block writer alignment feature The idea of the block align feature was to allow micro-managing that some files are forcefully aligned to 1k/4k ("device block") boundaries, hoping to improve access time at the cost of data density. The feature was not exposed in the tools for a long time and eventuall added to the sort file. Measurement and experimentation showed, that it in fact worsened the read performance on a test system with an old micro SD card as the bottle neck. The feature is removed, and if needed, can be brought back simply by wrapping/sub-classing the default block writer, if need be.. Signed-off-by: David Oberhollenzer --- include/sqfs/block_writer.h | 8 -------- 1 file changed, 8 deletions(-) (limited to 'include/sqfs/block_writer.h') diff --git a/include/sqfs/block_writer.h b/include/sqfs/block_writer.h index 6376d2e..84e6973 100644 --- a/include/sqfs/block_writer.h +++ b/include/sqfs/block_writer.h @@ -52,11 +52,6 @@ struct sqfs_block_writer_t { * @ref SQFS_BLK_LAST_BLOCK flag is set, it uses those stored locations * to do block deduplication. * - * If the flag @ref SQFS_BLK_ALIGN is set in combination with the - * @ref SQFS_BLK_FIRST_BLOCK, the file size is padded to a multiple of - * the device block size before writing. If it is set together with the - * @ref SQFS_BLK_LAST_BLOCK flag, the padding is added afterwards. - * * @param wr A pointer to a block writer. * @param user An optional user data pointer. * The @ref sqfs_block_processor_t can be told to pass this @@ -126,15 +121,12 @@ extern "C" { * @memberof sqfs_block_writer_t * * @param file A pointer to a file object that data should be appended to. - * @param devblksz The underlying device block size if output data - * should be aligned. * @param flags A combination of @ref SQFS_BLOCK_WRITER_FLAGS values. If an * unknown flag is set, creation will fail. * * @return A pointer to a new block writer on success, NULL on failure. */ SQFS_API sqfs_block_writer_t *sqfs_block_writer_create(sqfs_file_t *file, - size_t devblksz, sqfs_u32 flags); #ifdef __cplusplus -- cgit v1.2.3