From 32eb57dd9a19254565a0792ab9b627a3dac319f9 Mon Sep 17 00:00:00 2001 From: David Oberhollenzer Date: Sat, 4 Mar 2023 21:28:14 +0100 Subject: libsquashfs: remove the default block writer alignment feature The idea of the block align feature was to allow micro-managing that some files are forcefully aligned to 1k/4k ("device block") boundaries, hoping to improve access time at the cost of data density. The feature was not exposed in the tools for a long time and eventuall added to the sort file. Measurement and experimentation showed, that it in fact worsened the read performance on a test system with an old micro SD card as the bottle neck. The feature is removed, and if needed, can be brought back simply by wrapping/sub-classing the default block writer, if need be.. Signed-off-by: David Oberhollenzer --- bin/gensquashfs/test/sort_file.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'bin/gensquashfs/test/sort_file.c') diff --git a/bin/gensquashfs/test/sort_file.c b/bin/gensquashfs/test/sort_file.c index 951328e..6c6cce6 100644 --- a/bin/gensquashfs/test/sort_file.c +++ b/bin/gensquashfs/test/sort_file.c @@ -42,7 +42,7 @@ static const char *sort_file = " 50 [glob] /bin/*\n" "\n" "# Make this file appear first\n" -" -10000 [dont_compress,dont_fragment,align] /usr/share/bla.txt"; +" -10000 [dont_compress,dont_fragment] /usr/share/bla.txt"; static const char *initial_order[] = { "bin/chmod", @@ -93,7 +93,7 @@ static sqfs_s64 priorities[] = { }; static int flags[] = { - SQFS_BLK_DONT_COMPRESS | SQFS_BLK_ALIGN | SQFS_BLK_DONT_FRAGMENT, + SQFS_BLK_DONT_COMPRESS | SQFS_BLK_DONT_FRAGMENT, 0, 0, 0, -- cgit v1.2.3