From 569c430c61d7720919836e1fcbea27f7a0673778 Mon Sep 17 00:00:00 2001 From: David Oberhollenzer Date: Mon, 1 Jul 2019 10:38:01 +0200 Subject: Remove never used overflow error message in fstree_from_file Bug found using scan-build. Signed-off-by: David Oberhollenzer --- lib/fstree/fstree_from_file.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/lib/fstree/fstree_from_file.c b/lib/fstree/fstree_from_file.c index 0031c09..53c2cfb 100644 --- a/lib/fstree/fstree_from_file.c +++ b/lib/fstree/fstree_from_file.c @@ -181,7 +181,7 @@ static int handle_line(fstree_t *fs, const char *filename, x = line[i] - '0'; if (sb.st_uid > (0xFFFFFFFF - x) / 10) - goto fail_ov; + goto fail_ent; sb.st_uid = sb.st_uid * 10 + x; } @@ -200,7 +200,7 @@ static int handle_line(fstree_t *fs, const char *filename, x = line[i] - '0'; if (sb.st_gid > (0xFFFFFFFF - x) / 10) - goto fail_ov; + goto fail_ent; sb.st_gid = sb.st_gid * 10 + x; } @@ -235,9 +235,6 @@ fail_no_extra: fprintf(stderr, "%s: %zu: missing argument for %s.\n", filename, line_num, keyword); return -1; -fail_ov: - msg = "numeric overflow"; - goto fail_ent; fail_uid_gid: msg = "uid & gid must be decimal numbers"; goto out_desc; -- cgit v1.2.3