From 27ff810a59c0c5f10577403919117d9453d47d06 Mon Sep 17 00:00:00 2001 From: David Oberhollenzer Date: Tue, 30 Apr 2019 12:34:59 +0200 Subject: Cannonicalize path names read from the input file Signed-off-by: David Oberhollenzer --- lib/fstree/fstree_from_file.c | 8 ++++++-- mkfs/Makemodule.am | 2 +- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/lib/fstree/fstree_from_file.c b/lib/fstree/fstree_from_file.c index 66d71a2..7c6b9ba 100644 --- a/lib/fstree/fstree_from_file.c +++ b/lib/fstree/fstree_from_file.c @@ -1,5 +1,6 @@ /* SPDX-License-Identifier: GPL-3.0-or-later */ #include "fstree.h" +#include "util.h" #include #include @@ -253,9 +254,9 @@ static void trim_line(char *line) static int handle_line(fstree_t *fs, const char *filename, size_t line_num, char *line) { - const char *path, *extra = NULL, *msg = NULL; + const char *extra = NULL, *msg = NULL; unsigned int mode = 0, uid = 0, gid = 0, x; - char keyword[16]; + char keyword[16], *path; size_t i; /* isolate keyword */ @@ -288,6 +289,9 @@ static int handle_line(fstree_t *fs, const char *filename, while (isspace(line[i])) ++i; + if (canonicalize_name(path) || *path == '\0') + goto fail_ent; + /* mode */ if (!isdigit(line[i])) goto fail_mode; diff --git a/mkfs/Makemodule.am b/mkfs/Makemodule.am index 1f0acf2..f1afdf5 100644 --- a/mkfs/Makemodule.am +++ b/mkfs/Makemodule.am @@ -3,7 +3,7 @@ mksquashfs_SOURCES += mkfs/options.c mkfs/options.h mksquashfs_SOURCES += mkfs/meta_writer.c mkfs/meta_writer.h mksquashfs_SOURCES += mkfs/super.c mksquashfs_SOURCES += include/squashfs.h -mksquashfs_LDADD = libutil.a libfstree.a libcompress.a +mksquashfs_LDADD = libfstree.a libcompress.a libutil.a if WITH_LZMA mksquashfs_LDADD += $(XZ_LIBS) -- cgit v1.2.3