squashfs-tools-ng.git/lib, branch v1.1.3

Fix libsquashfs directory writer size accounting

2021-07-21T07:56:31+00:00

The squashfs readdir() implementation in the Linux kernel returns non-existing "." and ".." entries for offsets 0 and 1, and after that reads from disk. For convenience, it was decided to store an off-by-3 value on disk instead of doing complex primary school math to adjust for this. This didn't show up until now, because the kernel implementation trusts the value from the directory header more than the actual size in the inode and happily reads 3 more than the inode would allow it to. This only showed up with 7-zip which subtracts 3 from the size and expects the result to be exact and bails if the directory headers suggest otherwise. And yes, I did consider making a "Holy Hand Granade of Antioch" reference, but consciously decided not to. Signed-off-by: David Oberhollenzer

Fix printf format specifiers used for generating tarballs

2021-07-09T16:14:01+00:00

When processing files > 4G, using "%o" truncates the result and the tarball is not readable. This should have been discovered when auto-patching the printf format specifiers, but a cast was added instead and the issue was overlooked. This commit replaces the down-cast and printf format specifiers. Signed-off-by: David Oberhollenzer

libfstream: sanity check the buffer size in the gzip stream compressor

2021-06-25T13:15:05+00:00

Signed-off-by: David Oberhollenzer

Add default cases for every switch block

2021-06-25T13:12:41+00:00

Signed-off-by: David Oberhollenzer

Remove casual un-const casting in various places

2021-06-25T13:12:41+00:00

Signed-off-by: David Oberhollenzer

libutil: cleanup alignment trickery in mempool

2021-06-25T13:12:41+00:00

- Store the return value of the page allocation directly into the pool variable instead of an intermediate unsigned char pointer. - Make the blob[] array the same type as the bitmap, this saves us manual alignment trickery. - Cleanup the pointer arithmetic, let the compiler do the sizeof() multiplication. - Use uintptr_t for the manual alignment of the data pointer, so we don't run into signdness problems there. Signed-off-by: David Oberhollenzer

libsquashfs: get rid of potentially unaligned access and VLAs

2021-06-25T13:12:41+00:00

The same problem with the meta data header again, 16 bit read from a buffer: copy the buffer data into a 16 bit variable instead of casting to something potentially unaligned. Signed-off-by: David Oberhollenzer

libcommon: remove potentially un-aligned access in LZO compressor

2021-06-25T13:12:41+00:00

When accessing the 16 bit header, don't cast the buffer pointer to an uint16_t pointer, the result might not be aligned propperly. Instead memcpy to and from an uint16_t. Signed-off-by: David Oberhollenzer

libfstree: guard against possible overflow in readlink()

2021-06-25T13:12:41+00:00

*in theory*, say on a 32 bit system, we could have a 32 bit size_t and a 64 bit off_t. If the filesystem permitted this, we *could* then have a symlink with a target > 4G. Or the target is exacetely 4G, but adding a null-terminator could exceed addressable memory. This commit adds a check to guard against such an overflow and throw an error, instead of silently wrapping around. Signed-off-by: David Oberhollenzer

libfstree: guard against link count and inode number overflow

2021-06-25T13:12:41+00:00

If the hard link counter or the inode number counter overflow the maximum representable value (for SquashFS 16 bit and 32 bit respecitively), abort with an error message. Signed-off-by: David Oberhollenzer