squashfs-tools-ng.git/lib, branch fixes-1.0.0

Fix: libfstree: double free in error path

2022-08-19T16:59:52+00:00

If fstree_mknode fails, because the parent link count would overflow, the function fails and cleans up behind it. The problem arises because the function does this check *after* inserting the node in the parent node, so it is later free'd again, when destroying the rest of the tree. This patch moves the insertion after the check to mitigate the problem. Reported-by: Marvin Renich Signed-off-by: David Oberhollenzer

Fix: libfstree: actually use a full 32 bit hard link counter

2022-08-19T16:45:35+00:00

The squashfs on-disk format uses 32 bit link counters, but the fstree used 16 bit ones. Because the link count also includes child nodes, this artificially limited the number of entries in a directory to ~64k files. This patch removes the limit by switching libfstree to 32 bit counters. Reported-by: Marvin Renich Signed-off-by: David Oberhollenzer

Update built-in zlib version

2022-03-30T21:08:38+00:00

Signed-off-by: David Oberhollenzer

Fix: guard against potential overflow in file size calculation

2022-03-30T21:08:08+00:00

The block_count is a size_t, so on 32 bit platforms the multiplication might be truncated before the comparison with filesz. On 64 bit platforms, it could potentially also overflow the 64 bit bounds of the data type. Signed-off-by: David Oberhollenzer

Fix warning if __SIZEOF_INT128__ is not defined

2022-03-30T21:07:56+00:00

Signed-off-by: David Oberhollenzer

Cleanup libtar mkxattr, explicitly null-terminate strings

2022-03-30T21:07:52+00:00

Signed-off-by: David Oberhollenzer

Fix: consistently use the widechar file API on Windows

2022-03-30T21:04:35+00:00

When opening files on windows, use the widechar versions and convert from (assumed) UTF-8 to UTF-16 as needed. Since the broken, code-page-random API may acutall be intended in some use cases, leave that option in through an additional flag. Signed-off-by: David Oberhollenzer

Fix: libcommon: Correctly restore prefix path in mkdir_p on Windows

2021-11-25T21:18:02+00:00

Signed-off-by: David Oberhollenzer

Tighten bounds checks in sqfs_dir_reader_reader

2021-08-22T11:44:51+00:00

Use the same size check as sqfs_dir_reader_open_dir and report EOF, even if it is possible to read the header itself, but nothing beyond that. Also check if it should be possible to read an entry header before attempting and report EOF if not. Signed-off-by: David Oberhollenzer

Fix half done initialization of sqfs_dir_reader_open_dir

2021-08-22T11:44:46+00:00

The sqfs_dir_reader_open_dir function tried to take a short-cut by returning early if the target directory is empty. However, this left some field unchanged from the previous directory. If iterating over a directory and then deciding to enter a sub-directory that happens to be empty, the directory reader will keep the settings for the current directory. After calling sqfs_dir_reader_rewind, the sub-directory will suddenly report the contents of the parent. A similar check is added to the rewind function to not track back on the meta data reader in that case. Signed-off-by: David Oberhollenzer