squashfs-tools-ng.git/lib/tar, branch v0.6

Fix tar header error reporting on 32 bit systems

2019-08-03T08:51:34+00:00

If an extension header is rejected because its too big, the error path would print the size as size_t, altough it is an uint64_t. On 64 bit systems, this works because size_t is a 64 bit unsigned integer, on 32 bit systems, not so much. Signed-off-by: David Oberhollenzer

Add ability to write_tar_header to embedd extended attributes

2019-08-01T14:23:07+00:00

This commit patches the tar writer to generate a PAX header with SCHILY xattr key/value pairs if requested. The Schily format is used for two reasons: - It is simple - It is apparently more widely supported than the libarchive format Signed-off-by: David Oberhollenzer

Add propper copyright headers to all source files

2019-07-30T04:53:25+00:00

Signed-off-by: David Oberhollenzer

Use safer string copy function to fill tar header

2019-07-25T21:52:17+00:00

Signed-off-by: David Oberhollenzer

Enforce reasonable upper and low bounds on the size of tar headers

2019-07-25T21:35:15+00:00

Since they are read directly into memory, blindly allocating the size from the tar ball is probably a bad idea. Signed-off-by: David Oberhollenzer

Fix processing of tar mtime on 32 bit systems

2019-07-24T16:10:34+00:00

struct stat uses time_t to store time values. On some 32 bit systems, this may be a 32 bit integer. This patch adds a broken-out 64 bit time value to tar_header_decoded_t and makes sure to clamp the value to +/- (2^32 - 1) if required when writing it back to a struct stat. Reported-by: Matt Turner Signed-off-by: David Oberhollenzer

cleanup: remove atime/ctime processing code

2019-07-24T11:46:05+00:00

This commit removes all the code for parsing and processing atime/ctime and values and related test code. Caring about those is kind of pointless because squashfs can only store mtime in inodes. The only relevant place is when generating a struct stat from a squashfs inode or an fstree node. Signed-off-by: David Oberhollenzer

Enable largefile support

2019-07-24T07:16:16+00:00

Requires that config.h be included before other headers, since the macro _FILE_OFFSET_BITS changes the definitions of things like 'struct stat'. I chose to simply include it at the top of every C file and at immediately after the double-inclusion guards of every header. Signed-off-by: Matt Turner Signed-off-by: David Oberhollenzer

libtar: more lenient tar checksum verification

2019-07-23T23:03:42+00:00

Until now, the tar checksum verification simply copied the header, recomputed the checksum and compared it byte-for-byte with the original. However, not all implementations store the checksum the same way. For instance, git-archive generates tar balls that use the same format as for other octal numbers. This patch makes the checksum verification more lenient by parsing the checksum from the header and comparing it with the computed value instead of copying the entire block and insisting on byte-for-byte equivalence. The result is better interoperabillity with existing tools and perhaps slightly faster processing since the block doesn't have to be copied. Reported-by: Matt Turner Suggested-by: René Scharfe Signed-off-by: David Oberhollenzer

cleanup: move error handling into read_retry

2019-07-16T20:48:00+00:00

If read_retry fails to read the expected amount of data (EOF or otherwise), it is almost always an error. This commit renames read_retry to read_data and moves error handling into the function, making a lot of error handling code redundant. Signed-off-by: David Oberhollenzer