squashfs-tools-ng.git/lib/tar, branch fixes-1.1.0

Cleanup libtar mkxattr, explicitly null-terminate strings

2022-03-10T22:13:02+00:00

Signed-off-by: David Oberhollenzer

Fix printf format specifiers used for generating tarballs

2021-07-09T16:14:01+00:00

When processing files > 4G, using "%o" truncates the result and the tarball is not readable. This should have been discovered when auto-patching the printf format specifiers, but a cast was added instead and the issue was overlooked. This commit replaces the down-cast and printf format specifiers. Signed-off-by: David Oberhollenzer

Add default cases for every switch block

2021-06-25T13:12:41+00:00

Signed-off-by: David Oberhollenzer

Remove casual un-const casting in various places

2021-06-25T13:12:41+00:00

Signed-off-by: David Oberhollenzer

Remodel libtar/tar2sqfs to read data from an istream_t

2020-09-16T07:34:35+00:00

Signed-off-by: David Oberhollenzer

Remodel file extraction tools to use libfstream

2020-09-16T07:34:35+00:00

This commit rewrites the libtar write paths to use libfstream insead of a FILE pointer. Also, the libcommon file extraction function is remodeled to use libfstream. In accordance, rdsquashfs, sqfs2tar and sqfsdiff have some minor adjustments made to work with the ported libtar and libcommon. Signed-off-by: David Oberhollenzer

Fix integer bounds checking in GNU tar sparse format 1.0 parser

2020-09-03T16:28:09+00:00

- Make sure the file actually has that many records before trying to read one and fail if not. - Use the helper macros for size_t overflow checking instead of assuming size_t == uint64_t. - Impose a "reasonable" upper bound on the number of data segments and insist that there is at least one entry. Signed-off-by: David Oberhollenzer

Fix nonexistant gnu tar sparse format 1.0 support

2020-09-02T09:19:11+00:00

Contrary to previous claims, support for the GNU tar sparse format 1.0 was missing entirely (the newest of their 3 different sparse mapping formats). This oversight wasn't caught, because the unit test was compiling the wrong source file and tar2sqfs had no problem processing the test file because it is still a valid POSIX-ish tar archive (but the sparse part was missing and the mapping embedded in the file). Signed-off-by: David Oberhollenzer

Fix libtar treatment of link targets that fill the header field

2020-08-16T11:03:17+00:00

The tar header has a 100 byte field for symlink and hard link targets. If the target is longer than 100 bytes, an extension header has to be used. However, it is perfectly valid to fill all 100 bytes to the brim without adding a null terminator. In case of a symlink, this can result in garbage link targets, while for hard links it results in an immediate error since the target cannot be resolved later on. This commit attempts to fix the problem by replacing the strdup of the link target with an strndup that copies at most the size of the target header field. Signed-off-by: David Oberhollenzer

Cleanup: sqfs2tar: break up and simplify the repacking code

2020-05-30T15:49:40+00:00

- Move the xattr extraction and repacking to xattr.c - Don't on-the-fly delete the tar xattr list, use the function from libtar.a - Split minor tasks into static helper functions - creating a libtar xattr struct from libsqfs xattr data - finding a hard link entry from current path and inode number Signed-off-by: David Oberhollenzer