squashfs-tools-ng.git/lib/sqfs, branch v1.1.3

Fix libsquashfs directory writer size accounting

2021-07-21T07:56:31+00:00

The squashfs readdir() implementation in the Linux kernel returns non-existing "." and ".." entries for offsets 0 and 1, and after that reads from disk. For convenience, it was decided to store an off-by-3 value on disk instead of doing complex primary school math to adjust for this. This didn't show up until now, because the kernel implementation trusts the value from the directory header more than the actual size in the inode and happily reads 3 more than the inode would allow it to. This only showed up with 7-zip which subtracts 3 from the size and expects the result to be exact and bails if the directory headers suggest otherwise. And yes, I did consider making a "Holy Hand Granade of Antioch" reference, but consciously decided not to. Signed-off-by: David Oberhollenzer

Add default cases for every switch block

2021-06-25T13:12:41+00:00

Signed-off-by: David Oberhollenzer

Remove casual un-const casting in various places

2021-06-25T13:12:41+00:00

Signed-off-by: David Oberhollenzer

libsquashfs: get rid of potentially unaligned access and VLAs

2021-06-25T13:12:41+00:00

The same problem with the meta data header again, 16 bit read from a buffer: copy the buffer data into a 16 bit variable instead of casting to something potentially unaligned. Signed-off-by: David Oberhollenzer

libsquashfs: fix: also preserve alignment flag in block processor

2021-06-07T09:28:47+00:00

Currently, when the block processor aggreagtes fragments into a fragment block, it applies the "don't compress" flag if any of the original framgnets has it set, but the "align to device block" flag is lost. This commit ensures that both flags get applied to the fragment block if set. Signed-off-by: David Oberhollenzer

libsquashfs: fix block alignment if requested

2021-06-07T09:26:27+00:00

1) If the block alignment flag is set, the padding bytes must be inserted _before_ recording the start position, otherwise the resulting image is not readable. 2) Also perform alignment if the flag is set on a fragment block. Signed-off-by: David Oberhollenzer

Fix: libsquashfs: add sqfs_free() function

2021-04-08T10:04:33+00:00

On systems like Windows, the dynamic library and applications can easily end up being linked against different runtime libraries, so applications cannot be expected to be able to free() any malloc'd pointer that the library returns. This commit adds an sqfs_free function so the application can pass pointers back to the library to call the correct free() implementation. Signed-off-by: David Oberhollenzer

libsqfs: block processor: Fix account for manually submitted blocks

2021-03-30T10:42:43+00:00

This was already in the original block processor but got dropped by accident when restructuring it. The problem manifests itself when manually submitting fragment blocks. They no longer get correct I/O queue tickets, clog up the queue and the processor eventually throws an internal error. Signed-off-by: David Oberhollenzer

Fix fail branch in block processor fragment backend

2021-03-25T13:47:06+00:00

Only clean up the fragment if it hasn't been re-assigned to the fragment block. The NULL check is definitely wrong, because we no longer re-assign it as NULL. Signed-off-by: David Oberhollenzer

Fix block processor queue accounting

2021-03-24T13:05:18+00:00

Dequeuing won't work if we have a backlog of 1 or 2 and the blocks are used for internal buffering. Take that into account, similar to the sync code. Also bump the minimum backlog to 3, just to make absolutely sure we cannot run into a dequeue loop trying to allocate a block. Signed-off-by: David Oberhollenzer