squashfs-tools-ng.git/lib/sqfs, branch fixes-1.1.0

libsqfs: Initialize the return value in sqfs_compressor_create

2022-12-01T17:46:52+00:00

Initialize the output compressor pointer to NULL, so if the function fails, the value is propperly initialized to a NULL pointer instead of relying on the function user to initialize it. Signed-off-by: David Oberhollenzer

libsqfs: Fix an overzealous bounds check in the block processor

2022-12-01T17:46:52+00:00

When (during fragment deduplication) a fragment block is read back from disk and unpacked, it can happen that it is _exactly_ the given block size. The bounds check did '>=' instead of '>' and failed in that case with a "data corruption" error. Signed-off-by: David Oberhollenzer

Fix: guard against potential overflow in file size calculation

2022-03-10T22:31:54+00:00

The block_count is a size_t, so on 32 bit platforms the multiplication might be truncated before the comparison with filesz. On 64 bit platforms, it could potentially also overflow the 64 bit bounds of the data type. Signed-off-by: David Oberhollenzer

Fix: consistently use the widechar file API on Windows

2021-12-05T09:29:36+00:00

When opening files on windows, use the widechar versions and convert from (assumed) UTF-8 to UTF-16 as needed. Since the broken, code-page-random API may acutall be intended in some use cases, leave that option in through an additional flag. Signed-off-by: David Oberhollenzer

Tighten bounds checks in sqfs_dir_reader_reader

2021-08-22T11:45:15+00:00

Use the same size check as sqfs_dir_reader_open_dir and report EOF, even if it is possible to read the header itself, but nothing beyond that. Also check if it should be possible to read an entry header before attempting and report EOF if not. Signed-off-by: David Oberhollenzer

Fix half done initialization of sqfs_dir_reader_open_dir

2021-08-22T11:45:11+00:00

The sqfs_dir_reader_open_dir function tried to take a short-cut by returning early if the target directory is empty. However, this left some field unchanged from the previous directory. If iterating over a directory and then deciding to enter a sub-directory that happens to be empty, the directory reader will keep the settings for the current directory. After calling sqfs_dir_reader_rewind, the sub-directory will suddenly report the contents of the parent. A similar check is added to the rewind function to not track back on the meta data reader in that case. Signed-off-by: David Oberhollenzer

Fix libsquashfs directory writer size accounting

2021-07-21T07:56:31+00:00

The squashfs readdir() implementation in the Linux kernel returns non-existing "." and ".." entries for offsets 0 and 1, and after that reads from disk. For convenience, it was decided to store an off-by-3 value on disk instead of doing complex primary school math to adjust for this. This didn't show up until now, because the kernel implementation trusts the value from the directory header more than the actual size in the inode and happily reads 3 more than the inode would allow it to. This only showed up with 7-zip which subtracts 3 from the size and expects the result to be exact and bails if the directory headers suggest otherwise. And yes, I did consider making a "Holy Hand Granade of Antioch" reference, but consciously decided not to. Signed-off-by: David Oberhollenzer

Add default cases for every switch block

2021-06-25T13:12:41+00:00

Signed-off-by: David Oberhollenzer

Remove casual un-const casting in various places

2021-06-25T13:12:41+00:00

Signed-off-by: David Oberhollenzer

libsquashfs: get rid of potentially unaligned access and VLAs

2021-06-25T13:12:41+00:00

The same problem with the meta data header again, 16 bit read from a buffer: copy the buffer data into a 16 bit variable instead of casting to something potentially unaligned. Signed-off-by: David Oberhollenzer