squashfs-tools-ng.git/lib/fstree, branch fixes-1.1.0

Fix: libfstree: double free in error path

2022-08-19T16:54:24+00:00

If fstree_mknode fails, because the parent link count would overflow, the function fails and cleans up behind it. The problem arises because the function does this check *after* inserting the node in the parent node, so it is later free'd again, when destroying the rest of the tree. This patch moves the insertion after the check to mitigate the problem. Reported-by: Marvin Renich Signed-off-by: David Oberhollenzer

Fix: libfstree: actually use a full 32 bit hard link counter

2022-08-19T16:47:52+00:00

The squashfs on-disk format uses 32 bit link counters, but the fstree used 16 bit ones. Because the link count also includes child nodes, this artificially limited the number of entries in a directory to ~64k files. This patch removes the limit by switching libfstree to 32 bit counters. Reported-by: Marvin Renich Signed-off-by: David Oberhollenzer

libfstree: guard against possible overflow in readlink()

2021-06-25T13:12:41+00:00

*in theory*, say on a 32 bit system, we could have a 32 bit size_t and a 64 bit off_t. If the filesystem permitted this, we *could* then have a symlink with a target > 4G. Or the target is exacetely 4G, but adding a null-terminator could exceed addressable memory. This commit adds a check to guard against such an overflow and throw an error, instead of silently wrapping around. Signed-off-by: David Oberhollenzer

libfstree: guard against link count and inode number overflow

2021-06-25T13:12:41+00:00

If the hard link counter or the inode number counter overflow the maximum representable value (for SquashFS 16 bit and 32 bit respecitively), abort with an error message. Signed-off-by: David Oberhollenzer

libfstree: allow the glob path to be empty

2021-03-25T15:37:41+00:00

Signed-off-by: David Oberhollenzer

libfstree: add an assertion that root is not NULL

2021-03-25T13:49:52+00:00

If the path argument is "", we assume that referes to root and set the *existing* target node to the root node and skip ahead across the tree search. This leaves "name" uninitialized, which makes coverity panic, because fs->root could be NULL, going down the wrong path. Obviously, this should never, *ever* happen and there is no reasonable recovery strategy if it suddenly does, so simply add an assertion. Signed-off-by: David Oberhollenzer

libfstree: Allow / as argument for "glob" and "dir" commands

2021-03-25T13:35:39+00:00

This allows putting globbed files & directories into the filesystem root, as well as explicitly setting attributes of the root directory from the file lisiting. Signed-off-by: David Oberhollenzer

libfstree: implement directory scanning code for Windows

2021-03-24T08:59:07+00:00

It's rather simplistic and doesn't account for junction/reparse points, which is the closest thing Windows has to symlinks, hard links and mount points, but it's consistent with the unpacking code that assumes Windows only has files and directories. Using the 32 bit mingw toolchain, this seems to satisfy the unit tests on wine. Signed-off-by: David Oberhollenzer

Add libcompat fallback implementation for fnmatch

2021-03-20T16:46:14+00:00

This has basically been copied over from Musl and slightly modifed. Signed-off-by: David Oberhollenzer

Fix: libfstree: add an assert the canonicalize_name return value

2021-02-19T18:51:58+00:00

Since the canonicalize_name function only fails if the path contains ".." and the one we are constructing from the scanned fstree (built using canonicalized names), it should NEVER fail. However, coverity does get concerned, because we are checking the return value elesewhere. So do what we do at other, similar locations and add an assert(). Signed-off-by: David Oberhollenzer