squashfs-tools-ng.git/include/sqfs, branch fixes-1.2.0

Make sqfs_tree_node_get_path more robust

2022-07-08T17:17:35+00:00

Test against various invariants: - Every non-root node must have a name - The root node muts not have a name - The name must not be ".." or "." - The name must not contain '/' - The loop that chases parent pointers must terminate, i.e. we must never reach the starting state again (link loop). Furthermore, make sure the sum of all path components plus separators does not overflow. Signed-off-by: David Oberhollenzer

Move sqfs_tree_node_get_path to libsquashfs

2022-07-08T17:17:35+00:00

Signed-off-by: David Oberhollenzer

Cleanup: libsqfs: move directory iteration out of the directory reader

2022-06-02T15:26:53+00:00

Add a simple directory state object to the meta data reader and use that to iterate directory entries. The code for reading the directory listing is movde to readdir.c Signed-off-by: David Oberhollenzer

Add support for '.' and '..' entries in sqfs_dir_reader_t

2022-04-09T21:26:13+00:00

Two flags are added to the dir reader API, one for the create function that the dir reader should report those entries and one to the open function to suppress that if it was enabled. To implement the feature, a mapping of visited directory inodes is maintained internally, that mapps inode numbers to inode references. When opening a directory, state is maintained to generate the fake entries for '.' and '..'. Since all the other functions are based on the open/read/rewind API, no alterations need to be made. The tree scan function is modified, to use the suppress flag, so it does not accidentally catch those entries. Signed-off-by: David Oberhollenzer

sqfs_dir_tree_destroy/sqfs_destroy: allow NULL input

2022-03-30T20:31:30+00:00

Many library destructor functions (like free()) allow a NULL pointer as input, and do nothing in that case. This allows easier cleanup patterns: initialize pointers to NULL and then always pass them to the destroyer functions, no need for verbose goto/if-else patterns. Signed-off-by: Luca Boccassi

Fix: consistently use the widechar file API on Windows

2021-12-05T09:29:36+00:00

When opening files on windows, use the widechar versions and convert from (assumed) UTF-8 to UTF-16 as needed. Since the broken, code-page-random API may acutall be intended in some use cases, leave that option in through an additional flag. Signed-off-by: David Oberhollenzer

Fix libsquashfs directory writer size accounting

2021-07-21T07:56:31+00:00

The squashfs readdir() implementation in the Linux kernel returns non-existing "." and ".." entries for offsets 0 and 1, and after that reads from disk. For convenience, it was decided to store an off-by-3 value on disk instead of doing complex primary school math to adjust for this. This didn't show up until now, because the kernel implementation trusts the value from the directory header more than the actual size in the inode and happily reads 3 more than the inode would allow it to. This only showed up with 7-zip which subtracts 3 from the size and expects the result to be exact and bails if the directory headers suggest otherwise. And yes, I did consider making a "Holy Hand Granade of Antioch" reference, but consciously decided not to. Signed-off-by: David Oberhollenzer

Remove casual un-const casting in various places

2021-06-25T13:12:41+00:00

Signed-off-by: David Oberhollenzer

Fix: libsquashfs: allow static linking on Windows

2021-04-09T09:55:04+00:00

If SQFS_STATIC is defined, dummy out the SQFS_API definition, so we don't try to pull stuff from a (in this case) non-existant DLL or try to export functions. Signed-off-by: David Oberhollenzer

Fix: libsquashfs: add sqfs_free() function

2021-04-08T10:04:33+00:00

On systems like Windows, the dynamic library and applications can easily end up being linked against different runtime libraries, so applications cannot be expected to be able to free() any malloc'd pointer that the library returns. This commit adds an sqfs_free function so the application can pass pointers back to the library to call the correct free() implementation. Signed-off-by: David Oberhollenzer