From 6ccd7242c4c1404dafb64cd937adc3c65ce02385 Mon Sep 17 00:00:00 2001
From: Frank Haverkamp <haver@vnet.ibm.com>
Date: Wed, 21 Jun 2006 14:26:02 +0200
Subject: [MTD] UBI: Removed automake, autoconf, added ubi userspace headers.

Signed-off-by: Frank Haverkamp <haver@vnet.ibm.com>
---
 ubi-utils/src/ubigen.c | 369 +++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 369 insertions(+)
 create mode 100644 ubi-utils/src/ubigen.c

(limited to 'ubi-utils/src/ubigen.c')

diff --git a/ubi-utils/src/ubigen.c b/ubi-utils/src/ubigen.c
new file mode 100644
index 0000000..8a464dd
--- /dev/null
+++ b/ubi-utils/src/ubigen.c
@@ -0,0 +1,369 @@
+/*
+ * Copyright (c) International Business Machines Corp., 2006
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See
+ * the GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+ *
+ * Author: Oliver Lohmann
+ *
+ * Tool to add UBI headers to binary images.
+ *
+ * 1.0 Initial version
+ * 1.1 Different CRC32 start value
+ */
+
+#include <stdlib.h>
+#include <stdint.h>
+#include <stdio.h>
+#include <getopt.h>
+#include <argp.h>
+#include <unistd.h>
+#include <sys/stat.h>
+#include <mtd/ubi-header.h>
+
+#include "ubigen.h"
+#include "config.h"
+
+typedef enum action_t {
+	ACT_NORMAL	     = 0x00000001,
+	ACT_BROKEN_UPDATE    = 0x00000002,
+} action_t;
+
+
+const char *argp_program_version = PACKAGE_VERSION;
+const char *argp_program_bug_address = PACKAGE_BUGREPORT;
+static char doc[] = "\nVersion: " PACKAGE_VERSION "\n\tBuilt on "
+	BUILD_CPU" "BUILD_OS" at "__DATE__" "__TIME__"\n"
+	"\n"
+	"ubigen - a tool for adding UBI information to a binary input file.\n";
+
+static const char copyright [] __attribute__((unused)) =
+	"FIXME: insert license type"; /* FIXME */
+
+#define CHECK_ENDP(option, endp) do {			\
+	if (*endp) {					\
+		fprintf(stderr,				\
+			"Parse error option \'%s\'. "	\
+			"No correct numeric value.\n"	\
+			, option);			\
+		exit(EXIT_FAILURE);			\
+	}						\
+} while(0)
+
+static struct argp_option options[] = {
+	/* COMMON */
+	{ name: NULL, key: 0, arg: NULL, flags: 0,
+	  doc: "Common settings:",
+	  group: 1},
+
+	{ name: "copyright", key: 'c', arg: NULL,    flags: 0,
+	  doc: "Print copyright information.",
+	  group: 1 },
+
+	{ name: "verbose", key: 'v', arg: NULL,	   flags: 0,
+	  doc: "Print more progress information.",
+	  group: 1 },
+
+	{ name: "debug", key: 'd', arg: NULL, flags: 0,
+	  group: 1 },
+
+
+	/* INPUT */
+	{ name: NULL, key: 0, arg: NULL, flags: 0,
+	  doc: "UBI Settings:",
+	  group: 4},
+
+	{ name: "alignment", key: 'A', arg: "<num>", flags: 0,
+	  doc: "Set the alignment size to <num> (default 1).\n"
+	       "Values can be specified as bytes, 'ki' or 'Mi'.",
+	  group: 4 },
+
+	{ name: "blocksize", key: 'B', arg: "<num>", flags: 0,
+	  doc: "Set the eraseblock size to <num> (default 128 KiB).\n"
+	       "Values can be specified as bytes, 'ki' or 'Mi'.",
+	  group: 4 },
+
+	{ name: "erasecount", key: 'E', arg: "<num>", flags: 0,
+	  doc: "Set the erase count to <num> (default 0)",
+	  group: 4 },
+
+	{ name: "setver", key: 'X', arg: "<num>", flags: 0,
+	  doc: "Set UBI version number to <num> (default 1)",
+	  group: 4 },
+
+	{ name: "id", key: 'I', arg: "<num>", flags: 0,
+	  doc: "The UBI volume id.",
+	  group: 4 },
+
+
+	{ name: "offset", key: 'O', arg: "<num>", flags: 0,
+	  doc: "Offset from start of an erase block to the UBI volume header.",
+	  group: 4 },
+
+	{ name: "type", key: 'T', arg: "<num>", flags: 0,
+	  doc: "The UBI volume type:\n1 = dynamic, 2 = static",
+	  group: 4 },
+
+	/* INPUT/OUTPUT */
+	{ name: NULL, key: 0, arg: NULL, flags: 0,
+	  doc: "Input/Output:",
+	  group: 5 },
+
+	{ name: "infile", key: 'i', arg: "<filename>", flags: 0,
+	  doc: "Read input from file.",
+	  group: 5 },
+
+	{ name: "outfile", key: 'o', arg: "<filename>", flags: 0,
+	  doc: "Write output to file (default is stdout).",
+	  group: 5 },
+
+	/* Special options */
+	{ name: NULL, key: 0, arg: NULL, flags: 0,
+	  doc: "Special options:",
+	  group: 6 },
+
+	{ name: "broken-update", key: 'U', arg: "<leb>", flags: 0,
+	  doc: "Create an ubi image which simulates a broken update.\n"
+	       "<leb> specifies the logical eraseblock number to update.\n",
+	  group: 6 },
+
+	{ name: NULL, key: 0, arg: NULL, flags: 0, doc: NULL, group: 0 },
+};
+
+typedef struct myargs {
+	/* common settings */
+	action_t action;
+	int verbose;
+
+	int32_t id;
+	uint8_t type;
+	uint32_t eb_size;
+	uint64_t ec;
+	uint8_t version;
+	uint32_t hdr_offset;
+	uint32_t update_block;
+	uint32_t alignment;
+
+	FILE* fp_in;
+	FILE* fp_out;
+
+	/* special stuff needed to get additional arguments */
+	char *arg1;
+	char **options;			/* [STRING...] */
+} myargs;
+
+
+static int ustrtoul(const char *cp, char **endp, unsigned int base)
+{
+	unsigned long result = strtoul(cp, endp, base);
+
+	switch (**endp) {
+	case 'G':
+		result *= 1024;
+	case 'M':
+		result *= 1024;
+	case 'k':
+	case 'K':
+		result *= 1024;
+	/* "Ki", "ki", "Mi" or "Gi" are to be used. */
+		if ((*endp)[1] == 'i')
+			(*endp) += 2;
+	}
+	return result;
+}
+
+static error_t
+parse_opt(int key, char *arg, struct argp_state *state)
+{
+	int err = 0;
+	char* endp;
+
+	myargs *args = state->input;
+
+	switch (key) {
+	case 'c':
+		fprintf(stderr, "%s\n", copyright);
+		exit(0);
+		break;
+	case 'o': /* output */
+		args->fp_out = fopen(arg, "wb");
+		if ((args->fp_out) == NULL) {
+			fprintf(stderr, "Cannot open file %s for output\n",
+					arg);
+			exit(1);
+		}
+		break;
+	case 'i': /* input */
+		args->fp_in = fopen(arg, "rb");
+		if ((args->fp_in) == NULL) {
+			fprintf(stderr, "Cannot open file %s for input\n",
+					arg);
+			exit(1);
+		}
+		break;
+	case 'v': /* verbose */
+		args->verbose = 1;
+		break;
+
+	case 'B': /* eb_size */
+		args->eb_size = (uint32_t) ustrtoul(arg, &endp, 0);
+		CHECK_ENDP("B", endp);
+		break;
+	case 'E': /* erasecount */
+		args->ec = (uint64_t) strtoul(arg, &endp, 0);
+		CHECK_ENDP("E", endp);
+		break;
+	case 'I': /* id */
+		args->id = (uint16_t) strtoul(arg, &endp, 0);
+		CHECK_ENDP("I", endp);
+		break;
+	case 'T': /* type */
+		args->type =  (uint16_t) strtoul(arg, &endp, 0);
+		CHECK_ENDP("T", endp);
+		break;
+	case 'X': /* versionnr */
+		args->version =	 (uint8_t) strtoul(arg, &endp, 0);
+		CHECK_ENDP("X", endp);
+		break;
+	case 'O': /* offset for volume hdr */
+		args->hdr_offset =
+			(uint32_t) strtoul(arg, &endp, 0);
+		CHECK_ENDP("O", endp);
+		break;
+
+	case 'U': /* broken update */
+		args->action = ACT_BROKEN_UPDATE;
+		args->update_block =
+			(uint32_t) strtoul(arg, &endp, 0);
+		CHECK_ENDP("U", endp);
+		break;
+
+	case ARGP_KEY_ARG:
+		if (!args->fp_in) {
+			args->fp_in = fopen(arg, "rb");
+			if ((args->fp_in) == NULL) {
+				fprintf(stderr,
+				"Cannot open file %s for input\n", arg);
+				exit(1);
+			}
+		}
+		args->arg1 = arg;
+		args->options = &state->argv[state->next];
+		state->next = state->argc;
+		break;
+	case ARGP_KEY_END:
+
+		if (args->id < 0) {
+			err = 1;
+			fprintf(stderr,
+				"Please specify an UBI Volume ID.\n");
+		}
+		if (args->type == 0) {
+			err = 1;
+			fprintf(stderr,
+				"Please specify an UBI Volume type.\n");
+		}
+		if (err) {
+			fprintf(stderr, "\n");
+			argp_usage(state);
+			exit(1);
+		}
+		break;
+	default:
+		return(ARGP_ERR_UNKNOWN);
+	}
+
+	return 0;
+}
+
+static struct argp argp = {
+	options:     options,
+	parser:	     parse_opt,
+	args_doc:    0,
+	doc:	     doc,
+	children:    NULL,
+	help_filter: NULL,
+	argp_domain: NULL,
+};
+
+
+int
+main(int argc, char **argv)
+{
+	int rc = 0;
+	ubi_info_t u;
+	struct stat file_info;
+	off_t input_len = 0; /* only used in static volumes */
+
+	myargs args = {
+		.action = ACT_NORMAL,
+		.verbose = 0,
+
+		.id = -1,
+		.type = 0,
+		.eb_size = 0,
+		.update_block = 0,
+		.ec = 0,
+		.version = 0,
+		.hdr_offset = (DEFAULT_PAGESIZE) - (UBI_VID_HDR_SIZE),
+		.alignment = 1,
+
+		.fp_in = NULL,
+		.fp_out = stdout,
+		/* arguments */
+		.arg1 = NULL,
+		.options = NULL,
+	};
+
+	ubigen_init(); /* Init CRC32 table in ubigen */
+
+	/* parse arguments */
+	argp_parse(&argp, argc, argv, ARGP_IN_ORDER, 0, &args);
+
+	if (fstat(fileno(args.fp_in), &file_info) != 0) {
+		fprintf(stderr, "Cannot fetch file size "
+				"from input file.\n");
+	}
+	input_len = file_info.st_size;
+
+	rc = ubigen_create(&u, (uint32_t)args.id, args.type,
+			args.eb_size, args.ec, args.alignment,
+			args.version, args.hdr_offset, 0 ,input_len,
+			args.fp_in, args.fp_out);
+
+	if  (rc != 0) {
+		fprintf(stderr, "Cannot create UBI info handler rc: %d\n", rc);
+		exit(EXIT_FAILURE);
+	}
+
+	if (!args.fp_in || !args.fp_out) {
+		fprintf(stderr, "Input/Output error.\n");
+		exit(EXIT_FAILURE);
+
+	}
+
+	if (args.action & ACT_NORMAL) {
+		rc = ubigen_write_complete(u);
+	}
+	else if (args.action & ACT_BROKEN_UPDATE) {
+		rc = ubigen_write_broken_update(u, args.update_block);
+	}
+	if  (rc != 0) {
+		fprintf(stderr, "Error converting input data.\n");
+		exit(EXIT_FAILURE);
+	}
+
+	rc = ubigen_destroy(&u);
+	return rc;
+}
-- 
cgit v1.2.3


From 5b766e1b61ae0d525d7ef004014e0fdb7276eb24 Mon Sep 17 00:00:00 2001
From: Josh Boyer <jwboyer@linux.ibm.com>
Date: Mon, 11 Dec 2006 14:34:23 +0100
Subject: [PATCH 7/13] Convert ubigen to use getopt option parsing

Signed-off-by: Josh Boyer <jwboyer@linux.vnet.ibm.com>
Acked-by: Frank Haverkamp <haver@vnet.ibm.com>
---
 ubi-utils/src/ubigen.c | 349 ++++++++++++++++++++++++-------------------------
 1 file changed, 168 insertions(+), 181 deletions(-)

(limited to 'ubi-utils/src/ubigen.c')

diff --git a/ubi-utils/src/ubigen.c b/ubi-utils/src/ubigen.c
index 8a464dd..226834f 100644
--- a/ubi-utils/src/ubigen.c
+++ b/ubi-utils/src/ubigen.c
@@ -27,7 +27,6 @@
 #include <stdint.h>
 #include <stdio.h>
 #include <getopt.h>
-#include <argp.h>
 #include <unistd.h>
 #include <sys/stat.h>
 #include <mtd/ubi-header.h>
@@ -40,16 +39,79 @@ typedef enum action_t {
 	ACT_BROKEN_UPDATE    = 0x00000002,
 } action_t;
 
+extern char *optarg;
+extern int optind;
 
-const char *argp_program_version = PACKAGE_VERSION;
-const char *argp_program_bug_address = PACKAGE_BUGREPORT;
 static char doc[] = "\nVersion: " PACKAGE_VERSION "\n\tBuilt on "
 	BUILD_CPU" "BUILD_OS" at "__DATE__" "__TIME__"\n"
 	"\n"
 	"ubigen - a tool for adding UBI information to a binary input file.\n";
 
+static const char *optionsstr =
+" Common settings:\n"
+"  -c, --copyright            Print copyright information.\n"
+"  -d, --debug\n"
+"  -v, --verbose              Print more progress information.\n"
+"\n"
+" UBI Settings:\n"
+"  -A, --alignment=<num>      Set the alignment size to <num> (default 1).\n"
+"                             Values can be specified as bytes, 'ki' or 'Mi'.\n"
+"  -B, --blocksize=<num>      Set the eraseblock size to <num> (default 128\n"
+"                             KiB).\n"
+"                             Values can be specified as bytes, 'ki' or 'Mi'.\n"
+"  -E, --erasecount=<num>     Set the erase count to <num> (default 0)\n"
+"  -I, --id=<num>             The UBI volume id.\n"
+"  -O, --offset=<num>         Offset from start of an erase block to the UBI\n"
+"                             volume header.\n"
+"  -T, --type=<num>           The UBI volume type:\n"
+"                             1 = dynamic, 2 = static\n"
+"  -X, --setver=<num>         Set UBI version number to <num> (default 1)\n"
+"\n"
+" Input/Output:\n"
+"  -i, --infile=<filename>    Read input from file.\n"
+"  -o, --outfile=<filename>   Write output to file (default is stdout).\n"
+"\n"
+" Special options:\n"
+"  -U, --broken-update=<leb>  Create an ubi image which simulates a broken\n"
+"                             update.\n"
+"                             <leb> specifies the logical eraseblock number to\n"
+"                             update.\n"
+"\n"
+"  -?, --help                 Give this help list\n"
+"      --usage                Give a short usage message\n"
+"  -V, --version              Print program version\n";
+
+static const char *usage =
+"Usage: ubigen.orig [-cdv?V] [-A <num>] [-B <num>] [-E <num>] [-I <num>]\n"
+"          [-O <num>] [-T <num>] [-X <num>] [-i <filename>] [-o <filename>]\n"
+"          [-U <leb>] [--copyright] [--debug] [--verbose] [--alignment=<num>]\n"
+"          [--blocksize=<num>] [--erasecount=<num>] [--id=<num>]\n"
+"          [--offset=<num>] [--type=<num>] [--setver=<num>]\n"
+"          [--infile=<filename>] [--outfile=<filename>]\n"
+"          [--broken-update=<leb>] [--help] [--usage] [--version]\n";
+
+struct option long_options[] = {
+	{ .name = "copyright", .has_arg = 0, .flag = NULL, .val = 'c' },
+	{ .name = "debug", .has_arg = 0, .flag = NULL, .val = 'd' },
+	{ .name = "verbose", .has_arg = 0, .flag = NULL, .val = 'v' },
+	{ .name = "alignment", .has_arg = 1, .flag = NULL, .val = 'A' },
+	{ .name = "blocksize", .has_arg = 1, .flag = NULL, .val = 'B' },
+	{ .name = "erasecount", .has_arg = 1, .flag = NULL, .val = 'E' },
+	{ .name = "id", .has_arg = 1, .flag = NULL, .val = 'I' },
+	{ .name = "offset", .has_arg = 1, .flag = NULL, .val = 'O' },
+	{ .name = "type", .has_arg = 1, .flag = NULL, .val = 'T' },
+	{ .name = "setver", .has_arg = 1, .flag = NULL, .val = 'X' },
+	{ .name = "infile", .has_arg = 1, .flag = NULL, .val = 'i' },
+	{ .name = "outfile", .has_arg = 1, .flag = NULL, .val = 'o' },
+	{ .name = "broken-update", .has_arg = 1, .flag = NULL, .val = 'U' },
+	{ .name = "help", .has_arg = 0, .flag = NULL, .val = '?' },
+	{ .name = "usage", .has_arg = 0, .flag = NULL, .val = 0 },
+	{ .name = "version", .has_arg = 0, .flag = NULL, .val = 'V' },
+	{ NULL, 0, NULL, 0}
+};
+
 static const char copyright [] __attribute__((unused)) =
-	"FIXME: insert license type"; /* FIXME */
+	"Copyright IBM Corp 2006";
 
 #define CHECK_ENDP(option, endp) do {			\
 	if (*endp) {					\
@@ -61,86 +123,6 @@ static const char copyright [] __attribute__((unused)) =
 	}						\
 } while(0)
 
-static struct argp_option options[] = {
-	/* COMMON */
-	{ name: NULL, key: 0, arg: NULL, flags: 0,
-	  doc: "Common settings:",
-	  group: 1},
-
-	{ name: "copyright", key: 'c', arg: NULL,    flags: 0,
-	  doc: "Print copyright information.",
-	  group: 1 },
-
-	{ name: "verbose", key: 'v', arg: NULL,	   flags: 0,
-	  doc: "Print more progress information.",
-	  group: 1 },
-
-	{ name: "debug", key: 'd', arg: NULL, flags: 0,
-	  group: 1 },
-
-
-	/* INPUT */
-	{ name: NULL, key: 0, arg: NULL, flags: 0,
-	  doc: "UBI Settings:",
-	  group: 4},
-
-	{ name: "alignment", key: 'A', arg: "<num>", flags: 0,
-	  doc: "Set the alignment size to <num> (default 1).\n"
-	       "Values can be specified as bytes, 'ki' or 'Mi'.",
-	  group: 4 },
-
-	{ name: "blocksize", key: 'B', arg: "<num>", flags: 0,
-	  doc: "Set the eraseblock size to <num> (default 128 KiB).\n"
-	       "Values can be specified as bytes, 'ki' or 'Mi'.",
-	  group: 4 },
-
-	{ name: "erasecount", key: 'E', arg: "<num>", flags: 0,
-	  doc: "Set the erase count to <num> (default 0)",
-	  group: 4 },
-
-	{ name: "setver", key: 'X', arg: "<num>", flags: 0,
-	  doc: "Set UBI version number to <num> (default 1)",
-	  group: 4 },
-
-	{ name: "id", key: 'I', arg: "<num>", flags: 0,
-	  doc: "The UBI volume id.",
-	  group: 4 },
-
-
-	{ name: "offset", key: 'O', arg: "<num>", flags: 0,
-	  doc: "Offset from start of an erase block to the UBI volume header.",
-	  group: 4 },
-
-	{ name: "type", key: 'T', arg: "<num>", flags: 0,
-	  doc: "The UBI volume type:\n1 = dynamic, 2 = static",
-	  group: 4 },
-
-	/* INPUT/OUTPUT */
-	{ name: NULL, key: 0, arg: NULL, flags: 0,
-	  doc: "Input/Output:",
-	  group: 5 },
-
-	{ name: "infile", key: 'i', arg: "<filename>", flags: 0,
-	  doc: "Read input from file.",
-	  group: 5 },
-
-	{ name: "outfile", key: 'o', arg: "<filename>", flags: 0,
-	  doc: "Write output to file (default is stdout).",
-	  group: 5 },
-
-	/* Special options */
-	{ name: NULL, key: 0, arg: NULL, flags: 0,
-	  doc: "Special options:",
-	  group: 6 },
-
-	{ name: "broken-update", key: 'U', arg: "<leb>", flags: 0,
-	  doc: "Create an ubi image which simulates a broken update.\n"
-	       "<leb> specifies the logical eraseblock number to update.\n",
-	  group: 6 },
-
-	{ name: NULL, key: 0, arg: NULL, flags: 0, doc: NULL, group: 0 },
-};
-
 typedef struct myargs {
 	/* common settings */
 	action_t action;
@@ -183,120 +165,125 @@ static int ustrtoul(const char *cp, char **endp, unsigned int base)
 	return result;
 }
 
-static error_t
-parse_opt(int key, char *arg, struct argp_state *state)
+static int
+parse_opt(int argc, char **argv, myargs *args)
 {
 	int err = 0;
 	char* endp;
 
-	myargs *args = state->input;
-
-	switch (key) {
-	case 'c':
-		fprintf(stderr, "%s\n", copyright);
-		exit(0);
-		break;
-	case 'o': /* output */
-		args->fp_out = fopen(arg, "wb");
-		if ((args->fp_out) == NULL) {
-			fprintf(stderr, "Cannot open file %s for output\n",
-					arg);
-			exit(1);
-		}
-		break;
-	case 'i': /* input */
-		args->fp_in = fopen(arg, "rb");
-		if ((args->fp_in) == NULL) {
-			fprintf(stderr, "Cannot open file %s for input\n",
-					arg);
-			exit(1);
+	while (1) {
+		int key;
+
+		key = getopt_long(argc, argv, "cdvA:B:E:I:O:T:X:i:o:U:?V",
+				long_options, NULL);
+		if (key == -1)
+			break;
+
+		switch (key) {
+			case 'c':
+				fprintf(stderr, "%s\n", copyright);
+				exit(0);
+				break;
+			case 'o': /* output */
+				args->fp_out = fopen(optarg, "wb");
+				if ((args->fp_out) == NULL) {
+					fprintf(stderr, "Cannot open file %s for output\n",
+							optarg);
+					exit(1);
+				}
+				break;
+			case 'i': /* input */
+				args->fp_in = fopen(optarg, "rb");
+				if ((args->fp_in) == NULL) {
+					fprintf(stderr, "Cannot open file %s for input\n",
+							optarg);
+					exit(1);
+				}
+				break;
+			case 'v': /* verbose */
+				args->verbose = 1;
+				break;
+
+			case 'B': /* eb_size */
+				args->eb_size = (uint32_t) ustrtoul(optarg, &endp, 0);
+				CHECK_ENDP("B", endp);
+				break;
+			case 'E': /* erasecount */
+				args->ec = (uint64_t) strtoul(optarg, &endp, 0);
+				CHECK_ENDP("E", endp);
+				break;
+			case 'I': /* id */
+				args->id = (uint16_t) strtoul(optarg, &endp, 0);
+				CHECK_ENDP("I", endp);
+				break;
+			case 'T': /* type */
+				args->type =  (uint16_t) strtoul(optarg, &endp, 0);
+				CHECK_ENDP("T", endp);
+				break;
+			case 'X': /* versionnr */
+				args->version =	 (uint8_t) strtoul(optarg, &endp, 0);
+				CHECK_ENDP("X", endp);
+				break;
+			case 'O': /* offset for volume hdr */
+				args->hdr_offset =
+					(uint32_t) strtoul(optarg, &endp, 0);
+				CHECK_ENDP("O", endp);
+				break;
+
+			case 'U': /* broken update */
+				args->action = ACT_BROKEN_UPDATE;
+				args->update_block =
+					(uint32_t) strtoul(optarg, &endp, 0);
+				CHECK_ENDP("U", endp);
+				break;
+
+			case '?': /* help */
+				fprintf(stderr, "Usage: ubigen [OPTION...]\n");
+				fprintf(stderr, "%s", doc);
+				fprintf(stderr, "%s", optionsstr);
+				fprintf(stderr, "\nReport bugs to %s\n", PACKAGE_BUGREPORT);
+				exit(0);
+				break;
+
+			case 'V':
+				fprintf(stderr, "%s\n", PACKAGE_VERSION);
+				exit(0);
+				break;
+
+			default:
+				fprintf(stderr, "%s", usage);
+				exit(-1);
 		}
-		break;
-	case 'v': /* verbose */
-		args->verbose = 1;
-		break;
-
-	case 'B': /* eb_size */
-		args->eb_size = (uint32_t) ustrtoul(arg, &endp, 0);
-		CHECK_ENDP("B", endp);
-		break;
-	case 'E': /* erasecount */
-		args->ec = (uint64_t) strtoul(arg, &endp, 0);
-		CHECK_ENDP("E", endp);
-		break;
-	case 'I': /* id */
-		args->id = (uint16_t) strtoul(arg, &endp, 0);
-		CHECK_ENDP("I", endp);
-		break;
-	case 'T': /* type */
-		args->type =  (uint16_t) strtoul(arg, &endp, 0);
-		CHECK_ENDP("T", endp);
-		break;
-	case 'X': /* versionnr */
-		args->version =	 (uint8_t) strtoul(arg, &endp, 0);
-		CHECK_ENDP("X", endp);
-		break;
-	case 'O': /* offset for volume hdr */
-		args->hdr_offset =
-			(uint32_t) strtoul(arg, &endp, 0);
-		CHECK_ENDP("O", endp);
-		break;
-
-	case 'U': /* broken update */
-		args->action = ACT_BROKEN_UPDATE;
-		args->update_block =
-			(uint32_t) strtoul(arg, &endp, 0);
-		CHECK_ENDP("U", endp);
-		break;
-
-	case ARGP_KEY_ARG:
+	}
+
+	if (optind < argc) {
 		if (!args->fp_in) {
-			args->fp_in = fopen(arg, "rb");
+			args->fp_in = fopen(argv[optind++], "rb");
 			if ((args->fp_in) == NULL) {
 				fprintf(stderr,
-				"Cannot open file %s for input\n", arg);
+						"Cannot open file %s for input\n", argv[optind]);
 				exit(1);
 			}
 		}
-		args->arg1 = arg;
-		args->options = &state->argv[state->next];
-		state->next = state->argc;
-		break;
-	case ARGP_KEY_END:
-
-		if (args->id < 0) {
-			err = 1;
-			fprintf(stderr,
+	}
+	if (args->id < 0) {
+		err = 1;
+		fprintf(stderr,
 				"Please specify an UBI Volume ID.\n");
-		}
-		if (args->type == 0) {
-			err = 1;
-			fprintf(stderr,
+	}
+	if (args->type == 0) {
+		err = 1;
+		fprintf(stderr,
 				"Please specify an UBI Volume type.\n");
-		}
-		if (err) {
-			fprintf(stderr, "\n");
-			argp_usage(state);
-			exit(1);
-		}
-		break;
-	default:
-		return(ARGP_ERR_UNKNOWN);
+	}
+	if (err) {
+		fprintf(stderr, "%s", usage);
+		exit(1);
 	}
 
 	return 0;
 }
 
-static struct argp argp = {
-	options:     options,
-	parser:	     parse_opt,
-	args_doc:    0,
-	doc:	     doc,
-	children:    NULL,
-	help_filter: NULL,
-	argp_domain: NULL,
-};
-
 
 int
 main(int argc, char **argv)
@@ -329,7 +316,7 @@ main(int argc, char **argv)
 	ubigen_init(); /* Init CRC32 table in ubigen */
 
 	/* parse arguments */
-	argp_parse(&argp, argc, argv, ARGP_IN_ORDER, 0, &args);
+	parse_opt(argc, argv, &args);
 
 	if (fstat(fileno(args.fp_in), &file_info) != 0) {
 		fprintf(stderr, "Cannot fetch file size "
-- 
cgit v1.2.3


From da59698ccf81a1df3a250edb81a91f1b8a3decf0 Mon Sep 17 00:00:00 2001
From: Frank Haverkamp <haver@vnet.ibm.com>
Date: Mon, 11 Dec 2006 14:34:23 +0100
Subject: [MTD] UBI Utils: Tools should have individual version numbers

The tools had a mixture of different version numbers. This is changed now.
The internal change to move to remove glibc dependencies should be reflected
by an increase of the version number, so that we can react if trouble is
seen with the new code.

Singed-off-by: Frank Haverkamp <haver@vnet.ibm.com>
---
 ubi-utils/src/bin2nand.c     | 24 +++++++++++++++---------
 ubi-utils/src/config.h       |  4 ++--
 ubi-utils/src/mkbootenv.c    | 19 ++++++++++++-------
 ubi-utils/src/nand2bin.c     | 12 +++++++++---
 ubi-utils/src/pddcustomize.c | 22 +++++++++++++++-------
 ubi-utils/src/pfi2bin.c      |  9 ++++++---
 ubi-utils/src/pfiflash.c     |  2 +-
 ubi-utils/src/ubigen.c       | 35 +++++++++++++++++++++--------------
 ubi-utils/src/ubimirror.c    | 17 ++++++++++++-----
 ubi-utils/src/ubimkvol.c     | 16 ++++++++++------
 ubi-utils/src/ubirmvol.c     | 11 +++++++----
 ubi-utils/src/ubiupdatevol.c |  2 +-
 ubi-utils/src/unubi.c        |  4 +++-
 13 files changed, 114 insertions(+), 63 deletions(-)

(limited to 'ubi-utils/src/ubigen.c')

diff --git a/ubi-utils/src/bin2nand.c b/ubi-utils/src/bin2nand.c
index df838af..4bab1ad 100644
--- a/ubi-utils/src/bin2nand.c
+++ b/ubi-utils/src/bin2nand.c
@@ -22,10 +22,11 @@
  * Create a flashable NAND image from a binary image
  *
  * History:
- *	1.0:	Initial release (tglx)
- *	1.1:	Understands hex and dec input parameters (tglx)
- *	1.2:	Generates separated OOB data, if needed. (oloh)
- *	1.3:	Padds data/oob to a given size. (oloh)
+ * 1.0 Initial release (tglx)
+ * 1.1 Understands hex and dec input parameters (tglx)
+ * 1.2 Generates separated OOB data, if needed. (oloh)
+ * 1.3 Padds data/oob to a given size. (oloh)
+ * 1.4 Removed argp because we want to use uClibc.
  */
 
 #include <unistd.h>
@@ -44,6 +45,8 @@
 #include "config.h"
 #include "nandecc.h"
 
+#define PROGRAM_VERSION "1.4"
+
 #define CHECK_ENDP(option, endp) do {			\
 	if (*endp) {					\
 		fprintf(stderr,				\
@@ -65,7 +68,7 @@ typedef enum action_t {
 extern char *optarg;
 extern int optind;
 
-static char doc[] = "\nVersion: " PACKAGE_VERSION "\n\tBuilt on "
+static char doc[] = "\nVersion: " PROGRAM_VERSION "\n\tBuilt on "
 	BUILD_CPU" "BUILD_OS" at "__DATE__" "__TIME__"\n"
 	"\n"
 	"bin2nand - a tool for adding OOB information to a "
@@ -153,11 +156,13 @@ parse_opt(int argc, char **argv, myargs *args)
 
 		switch (key) {
 			case 'p': /* pagesize */
-				args->pagesize = (size_t) ustrtoull(optarg, &endp, 0);
+				args->pagesize = (size_t)
+					ustrtoull(optarg, &endp, 0);
 				CHECK_ENDP("p", endp);
 				break;
 			case 'j': /* padding */
-				args->padding = (size_t) ustrtoull(optarg, &endp, 0);
+				args->padding = (size_t)
+					ustrtoull(optarg, &endp, 0);
 				CHECK_ENDP("j", endp);
 				break;
 			case 'o': /* output */
@@ -172,7 +177,7 @@ parse_opt(int argc, char **argv, myargs *args)
 				exit(0);
 				break;
 			case 'V':
-				printf("%s\n", PACKAGE_VERSION);
+				printf("%s\n", PROGRAM_VERSION);
 				exit(0);
 				break;
 			case 'c':
@@ -187,7 +192,8 @@ parse_opt(int argc, char **argv, myargs *args)
 	if (optind < argc) {
 		args->fp_in = fopen(argv[optind++], "rb");
 		if ((args->fp_in) == NULL) {
-			err_quit("Cannot open file %s for input\n", argv[optind++]);
+			err_quit("Cannot open file %s for input\n",
+				 argv[optind++]);
 		}
 	}
 
diff --git a/ubi-utils/src/config.h b/ubi-utils/src/config.h
index b5bbd5b..8c4dd54 100644
--- a/ubi-utils/src/config.h
+++ b/ubi-utils/src/config.h
@@ -20,8 +20,8 @@
  * Author: Frank Haverkamp
  */
 
-#define PACKAGE_VERSION     "1.1"
-#define PACKAGE_BUGREPORT   "haver@vnet.ibm.com, dedekind@linutronix.de, or tglx@linutronix.de"
+#define PACKAGE_BUGREPORT						\
+	"haver@vnet.ibm.com, dedekind@linutronix.de, or tglx@linutronix.de"
 
 #define __unused __attribute__((unused))
 
diff --git a/ubi-utils/src/mkbootenv.c b/ubi-utils/src/mkbootenv.c
index a556939..c05f4e2 100644
--- a/ubi-utils/src/mkbootenv.c
+++ b/ubi-utils/src/mkbootenv.c
@@ -18,6 +18,8 @@
  * Author: Oliver Lohmann
  *
  * Create boot-parameter/pdd data from an ASCII-text input file.
+ *
+ * 1.2 Removed argp because we want to use uClibc.
  */
 
 #include <stdio.h>
@@ -32,10 +34,12 @@
 #include "bootenv.h"
 #include "error.h"
 
+#define PROGRAM_VERSION "1.2"
+
 extern char *optarg;
 extern int optind;
 
-static char doc[] = "\nVersion: " PACKAGE_VERSION "\n\tBuilt on "
+static char doc[] = "\nVersion: " PROGRAM_VERSION "\n\tBuilt on "
 	BUILD_CPU" "BUILD_OS" at "__DATE__" "__TIME__"\n"
 	"\n"
 	"mkbootenv - processes bootenv text files and convertes "
@@ -91,19 +95,20 @@ parse_opt(int argc, char **argv, myargs *args)
 			case 'o':
 				args->fp_out = fopen(optarg, "wb");
 				if ((args->fp_out) == NULL) {
-					fprintf(stderr,
-							"Cannot open file %s for output\n", optarg);
+					fprintf(stderr, "Cannot open file %s "
+						"for output\n", optarg);
 					exit(1);
 				}
 				break;
 			case '?': /* help */
 				printf("%s", doc);
 				printf("%s", optionsstr);
-				printf("\nReport bugs to %s\n", PACKAGE_BUGREPORT);
+				printf("\nReport bugs to %s\n",
+				       PACKAGE_BUGREPORT);
 				exit(0);
 				break;
 			case 'V':
-				printf("%s\n", PACKAGE_VERSION);
+				printf("%s\n", PROGRAM_VERSION);
 				exit(0);
 				break;
 			default:
@@ -115,8 +120,8 @@ parse_opt(int argc, char **argv, myargs *args)
 	if (optind < argc) {
 		args->fp_in = fopen(argv[optind++], "rb");
 		if ((args->fp_in) == NULL) {
-			fprintf(stderr,
-					"Cannot open file %s for input\n", argv[optind]);
+			fprintf(stderr,	"Cannot open file %s for input\n",
+				argv[optind]);
 			exit(1);
 		}
 	}
diff --git a/ubi-utils/src/nand2bin.c b/ubi-utils/src/nand2bin.c
index a9b68bd..34cce40 100644
--- a/ubi-utils/src/nand2bin.c
+++ b/ubi-utils/src/nand2bin.c
@@ -18,7 +18,10 @@
  * Author: Frank Haverkamp
  *
  * An utility to decompose NAND images and strip OOB off. Not yet finished ...
+ *
+ * 1.2 Removed argp because we want to use uClibc.
  */
+
 #include <config.h>
 #include <errno.h>
 #include <fcntl.h>
@@ -36,6 +39,8 @@
 #include "config.h"
 #include "nandecc.h"
 
+#define PROGRAM_VERSION "1.2"
+
 #define MAXPATH		1024
 #define MIN(x,y)	((x)<(y)?(x):(y))
 
@@ -60,7 +65,7 @@ static struct args myargs = {
 	.options = NULL,
 };
 
-static char doc[] = "\nVersion: " PACKAGE_VERSION "\n\t"
+static char doc[] = "\nVersion: " PROGRAM_VERSION "\n\t"
 	BUILD_OS" "BUILD_CPU" at "__DATE__" "__TIME__"\n"
 	"\nSplit data and OOB.\n";
 
@@ -147,12 +152,13 @@ parse_opt(int argc, char **argv, struct args *args)
 				printf("Usage: nand2bin [OPTION...] input.mif\n");
 				printf("%s", doc);
 				printf("%s", optionsstr);
-				printf("\nReport bugs to %s\n", PACKAGE_BUGREPORT);
+				printf("\nReport bugs to %s\n",
+				       PACKAGE_BUGREPORT);
 				exit(0);
 				break;
 
 			case 'V':
-				printf("%s\n", PACKAGE_VERSION);
+				printf("%s\n", PROGRAM_VERSION);
 				exit(0);
 				break;
 
diff --git a/ubi-utils/src/pddcustomize.c b/ubi-utils/src/pddcustomize.c
index 5d1864a..5c2a5f0 100644
--- a/ubi-utils/src/pddcustomize.c
+++ b/ubi-utils/src/pddcustomize.c
@@ -23,6 +23,8 @@
  * if the system is updated and one must be able to modify them when
  * the system has booted the first time. This tool is intended to do
  * PDD modification.
+ *
+ * 1.3 Removed argp because we want to use uClibc.
  */
 
 #include <stdio.h>
@@ -41,6 +43,8 @@
 #include "libubi.h"
 #include "ubimirror.h"
 
+#define PROGRAM_VERSION "1.3"
+
 typedef enum action_t {
 	ACT_NORMAL   = 0,
 	ACT_LIST,
@@ -59,7 +63,7 @@ typedef enum action_t {
 extern char *optarg;
 extern int optind;
 
-static char doc[] = "\nVersion: " PACKAGE_VERSION "\n\tBuilt on "
+static char doc[] = "\nVersion: " PROGRAM_VERSION "\n\tBuilt on "
 	BUILD_CPU" "BUILD_OS" at "__DATE__" "__TIME__"\n"
 	"\n"
 	"pddcustomize - customize bootenv and pdd values.\n";
@@ -160,7 +164,8 @@ parse_opt(int argc, char **argv, myargs *args)
 	while (1) {
 		int key;
 
-		key = getopt_long(argc, argv, "clbxs:i:o:?V", long_options, NULL);
+		key = getopt_long(argc, argv, "clbxs:i:o:?V",
+				  long_options, NULL);
 		if (key == -1)
 			break;
 
@@ -182,8 +187,9 @@ parse_opt(int argc, char **argv, myargs *args)
 				args->side = get_update_side(optarg);
 				if (args->side < 0) {
 					err_msg("Unsupported seqnum: %d.\n"
-							"Supported seqnums are '0' and '1'\n",
-							args->side, optarg);
+						"Supported seqnums are "
+						"'0' and '1'\n",
+						args->side, optarg);
 					ERR_ARGP;
 				}
 				break;
@@ -194,14 +200,16 @@ parse_opt(int argc, char **argv, myargs *args)
 				args->file_out = optarg;
 				break;
 			case '?': /* help */
-				err_msg("Usage: pddcustomize.orig [OPTION...] [key=value] [...]");
+				err_msg("Usage: pddcustomize.orig [OPTION...] "
+					"[key=value] [...]");
 				err_msg("%s", doc);
 				err_msg("%s", optionsstr);
-				err_msg("\nReport bugs to %s", PACKAGE_BUGREPORT);
+				err_msg("\nReport bugs to %s",
+					PACKAGE_BUGREPORT);
 				exit(0);
 				break;
 			case 'V':
-				err_msg("%s", PACKAGE_VERSION);
+				err_msg("%s", PROGRAM_VERSION);
 				exit(0);
 				break;
 			default:
diff --git a/ubi-utils/src/pfi2bin.c b/ubi-utils/src/pfi2bin.c
index 044fa24..9265fd5 100644
--- a/ubi-utils/src/pfi2bin.c
+++ b/ubi-utils/src/pfi2bin.c
@@ -22,6 +22,8 @@
  * chips in a manufacturing step where the flashes are written before
  * being soldered onto the hardware. For NAND images another step is
  * required to add the right OOB data to the binary image.
+ *
+ * 1.3 Removed argp because we want to use uClibc.
  */
 
 #include <stdlib.h>
@@ -42,7 +44,7 @@
 #include "peb.h"
 #include "crc32.h"
 
-#define PROGRAM_VERSION "1.2"
+#define PROGRAM_VERSION "1.3"
 
 #define MAX_FNAME 255
 #define DEFAULT_ERASE_COUNT  0 /* Hmmm.... Perhaps */
@@ -157,12 +159,13 @@ parse_opt(int argc, char **argv, myargs *args)
 				printf("pfi2bin [OPTION...] pfifile\n");
 				printf("%s", doc);
 				printf("%s", optionsstr);
-				printf("\nReport bugs to %s\n", PACKAGE_BUGREPORT);
+				printf("\nReport bugs to %s\n",
+				       PACKAGE_BUGREPORT);
 				exit(0);
 				break;
 
 			case 'V':
-				printf("%s\n", PACKAGE_VERSION);
+				printf("%s\n", PROGRAM_VERSION);
 				exit(0);
 				break;
 
diff --git a/ubi-utils/src/pfiflash.c b/ubi-utils/src/pfiflash.c
index 259a647..63487b9 100644
--- a/ubi-utils/src/pfiflash.c
+++ b/ubi-utils/src/pfiflash.c
@@ -193,7 +193,7 @@ parse_opt(int argc, char **argv, myargs *args)
 				exit(0);
 				break;
 			case 'V':
-				err_msg("%s", PACKAGE_VERSION);
+				err_msg("%s", PROGRAM_VERSION);
 				exit(0);
 				break;
 			default:
diff --git a/ubi-utils/src/ubigen.c b/ubi-utils/src/ubigen.c
index 226834f..877f469 100644
--- a/ubi-utils/src/ubigen.c
+++ b/ubi-utils/src/ubigen.c
@@ -21,6 +21,7 @@
  *
  * 1.0 Initial version
  * 1.1 Different CRC32 start value
+ * 1.2 Removed argp because we want to use uClibc.
  */
 
 #include <stdlib.h>
@@ -34,6 +35,8 @@
 #include "ubigen.h"
 #include "config.h"
 
+#define PROGRAM_VERSION "1.2"
+
 typedef enum action_t {
 	ACT_NORMAL	     = 0x00000001,
 	ACT_BROKEN_UPDATE    = 0x00000002,
@@ -42,7 +45,7 @@ typedef enum action_t {
 extern char *optarg;
 extern int optind;
 
-static char doc[] = "\nVersion: " PACKAGE_VERSION "\n\tBuilt on "
+static char doc[] = "\nVersion: " PROGRAM_VERSION "\n\tBuilt on "
 	BUILD_CPU" "BUILD_OS" at "__DATE__" "__TIME__"\n"
 	"\n"
 	"ubigen - a tool for adding UBI information to a binary input file.\n";
@@ -187,16 +190,16 @@ parse_opt(int argc, char **argv, myargs *args)
 			case 'o': /* output */
 				args->fp_out = fopen(optarg, "wb");
 				if ((args->fp_out) == NULL) {
-					fprintf(stderr, "Cannot open file %s for output\n",
-							optarg);
+					fprintf(stderr, "Cannot open file %s "
+						"for output\n", optarg);
 					exit(1);
 				}
 				break;
 			case 'i': /* input */
 				args->fp_in = fopen(optarg, "rb");
 				if ((args->fp_in) == NULL) {
-					fprintf(stderr, "Cannot open file %s for input\n",
-							optarg);
+					fprintf(stderr, "Cannot open file %s "
+						"for input\n", optarg);
 					exit(1);
 				}
 				break;
@@ -205,23 +208,26 @@ parse_opt(int argc, char **argv, myargs *args)
 				break;
 
 			case 'B': /* eb_size */
-				args->eb_size = (uint32_t) ustrtoul(optarg, &endp, 0);
+				args->eb_size =
+					(uint32_t)ustrtoul(optarg, &endp, 0);
 				CHECK_ENDP("B", endp);
 				break;
 			case 'E': /* erasecount */
-				args->ec = (uint64_t) strtoul(optarg, &endp, 0);
+				args->ec = (uint64_t)strtoul(optarg, &endp, 0);
 				CHECK_ENDP("E", endp);
 				break;
 			case 'I': /* id */
-				args->id = (uint16_t) strtoul(optarg, &endp, 0);
+				args->id = (uint16_t)strtoul(optarg, &endp, 0);
 				CHECK_ENDP("I", endp);
 				break;
 			case 'T': /* type */
-				args->type =  (uint16_t) strtoul(optarg, &endp, 0);
+				args->type =
+					(uint16_t)strtoul(optarg, &endp, 0);
 				CHECK_ENDP("T", endp);
 				break;
 			case 'X': /* versionnr */
-				args->version =	 (uint8_t) strtoul(optarg, &endp, 0);
+				args->version =
+					(uint8_t)strtoul(optarg, &endp, 0);
 				CHECK_ENDP("X", endp);
 				break;
 			case 'O': /* offset for volume hdr */
@@ -241,12 +247,13 @@ parse_opt(int argc, char **argv, myargs *args)
 				fprintf(stderr, "Usage: ubigen [OPTION...]\n");
 				fprintf(stderr, "%s", doc);
 				fprintf(stderr, "%s", optionsstr);
-				fprintf(stderr, "\nReport bugs to %s\n", PACKAGE_BUGREPORT);
+				fprintf(stderr, "\nReport bugs to %s\n",
+					PACKAGE_BUGREPORT);
 				exit(0);
 				break;
 
 			case 'V':
-				fprintf(stderr, "%s\n", PACKAGE_VERSION);
+				fprintf(stderr, "%s\n", PROGRAM_VERSION);
 				exit(0);
 				break;
 
@@ -260,8 +267,8 @@ parse_opt(int argc, char **argv, myargs *args)
 		if (!args->fp_in) {
 			args->fp_in = fopen(argv[optind++], "rb");
 			if ((args->fp_in) == NULL) {
-				fprintf(stderr,
-						"Cannot open file %s for input\n", argv[optind]);
+				fprintf(stderr,	"Cannot open file %s for "
+					"input\n", argv[optind]);
 				exit(1);
 			}
 		}
diff --git a/ubi-utils/src/ubimirror.c b/ubi-utils/src/ubimirror.c
index 1b1d0be..533a0ee 100644
--- a/ubi-utils/src/ubimirror.c
+++ b/ubi-utils/src/ubimirror.c
@@ -16,6 +16,8 @@
  * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
  *
  * Author: Oliver Lohmann
+ *
+ * 1.2 Removed argp because we want to use uClibc.
  */
 
 #include <stdio.h>
@@ -32,6 +34,8 @@
 #include "example_ubi.h"
 #include "ubimirror.h"
 
+#define PROGRAM_VERSION "1.2"
+
 typedef enum action_t {
 	ACT_NORMAL = 0,
 	ACT_ARGP_ABORT,
@@ -51,7 +55,7 @@ typedef enum action_t {
 extern char *optarg;
 extern int optind;
 
-static char doc[] = "\nVersion: " PACKAGE_VERSION "\n\tBuilt on "
+static char doc[] = "\nVersion: " PROGRAM_VERSION "\n\tBuilt on "
 	BUILD_CPU" "BUILD_OS" at "__DATE__" "__TIME__"\n"
 	"\n"
 	"ubimirror - mirrors ubi volumes.\n";
@@ -122,19 +126,22 @@ parse_opt(int argc, char **argv, myargs *args)
 				args->side = get_update_side(optarg);
 				if (args->side < 0) {
 					err_msg("Unsupported seqnum: %s.\n"
-							"Supported seqnums are '0' and '1'\n", optarg);
+						"Supported seqnums are '0' "
+						"and '1'\n", optarg);
 					ERR_ARGP;
 				}
 				break;
 			case '?': /* help */
-				err_msg("Usage: ubimirror [OPTION...] <source> <destination>\n");
+				err_msg("Usage: ubimirror [OPTION...] "
+					"<source> <destination>\n");
 				err_msg("%s", doc);
 				err_msg("%s", optionsstr);
-				err_msg("\nReport bugs to %s\n", PACKAGE_BUGREPORT);
+				err_msg("\nReport bugs to %s\n",
+					PACKAGE_BUGREPORT);
 				exit(0);
 				break;
 			case 'V':
-				err_msg("%s", PACKAGE_VERSION);
+				err_msg("%s", PROGRAM_VERSION);
 				exit(0);
 				break;
 			default:
diff --git a/ubi-utils/src/ubimkvol.c b/ubi-utils/src/ubimkvol.c
index 7d510eb..e878d70 100644
--- a/ubi-utils/src/ubimkvol.c
+++ b/ubi-utils/src/ubimkvol.c
@@ -26,6 +26,7 @@
  * 1.1 Does not support erase blocks anymore. This is replaced by
  *     the number of bytes.
  * 1.2 Reworked the user-interface to use argp.
+ * 1.3 Removed argp because we want to use uClibc.
  */
 
 #include <stdio.h>
@@ -38,7 +39,7 @@
 #include <config.h>
 #include <libubi.h>
 
-#define PROGRAM_VERSION "1.2"
+#define PROGRAM_VERSION "1.3"
 
 extern char *optarg;
 extern int optind;
@@ -179,10 +180,12 @@ parse_opt(int argc, char **argv, struct args *args)
 				break;
 			case 'n': /* --volid=<volume id> */
 				args->vol_id = strtoul(optarg, &endp, 0);
-				if (*endp != '\0' || endp == optarg ||
-						(args->vol_id < 0 && args->vol_id != UBI_DYNAMIC_VOLUME)) {
+				if (*endp != '\0' ||
+				    endp == optarg ||
+				    (args->vol_id < 0 &&
+				     args->vol_id != UBI_DYNAMIC_VOLUME)) {
 					fprintf(stderr, "Bad volume ID: "
-							"\"%s\"\n", optarg);
+						"\"%s\"\n", optarg);
 					goto out;
 				}
 				break;
@@ -199,12 +202,13 @@ parse_opt(int argc, char **argv, struct args *args)
 				fprintf(stderr, "Usage: ubimkvol [OPTION...]\n");
 				fprintf(stderr, "%s", doc);
 				fprintf(stderr, "%s", optionsstr);
-				fprintf(stderr, "\nReport bugs to %s\n", PACKAGE_BUGREPORT);
+				fprintf(stderr, "\nReport bugs to %s\n",
+					PACKAGE_BUGREPORT);
 				exit(0);
 				break;
 
 			case 'V':
-				fprintf(stderr, "%s\n", PACKAGE_VERSION);
+				fprintf(stderr, "%s\n", PROGRAM_VERSION);
 				exit(0);
 				break;
 
diff --git a/ubi-utils/src/ubirmvol.c b/ubi-utils/src/ubirmvol.c
index 69e4d0e..04ec085 100644
--- a/ubi-utils/src/ubirmvol.c
+++ b/ubi-utils/src/ubirmvol.c
@@ -23,6 +23,7 @@
  *         Frank Haverkamp <haver@vnet.ibm.com>
  *
  * 1.1 Reworked the userinterface to use argp.
+ * 1.2 Removed argp because we want to use uClibc.
  */
 
 #include <stdio.h>
@@ -35,7 +36,7 @@
 #include <config.h>
 #include <libubi.h>
 
-#define PROGRAM_VERSION "1.1"
+#define PROGRAM_VERSION "1.2"
 
 extern char *optarg;
 extern int optind;
@@ -123,7 +124,8 @@ parse_opt(int argc, char **argv, struct args *args)
 			case 'n': /* --volid=<volume id> */
 				args->vol_id = strtoul(optarg, &endp, 0);
 				if (*endp != '\0' || endp == optarg ||
-						(args->vol_id < 0 && args->vol_id != UBI_DYNAMIC_VOLUME)) {
+				    (args->vol_id < 0 &&
+				     args->vol_id != UBI_DYNAMIC_VOLUME)) {
 					fprintf(stderr, "Bad volume ID: "
 							"\"%s\"\n", optarg);
 					goto out;
@@ -136,11 +138,12 @@ parse_opt(int argc, char **argv, struct args *args)
 				fprintf(stderr, "Usage: ubirmvol [OPTION...]\n");
 				fprintf(stderr, "%s", doc);
 				fprintf(stderr, "%s", optionsstr);
-				fprintf(stderr, "\nReport bugs to %s\n", PACKAGE_BUGREPORT);
+				fprintf(stderr, "\nReport bugs to %s\n",
+					PACKAGE_BUGREPORT);
 				exit(0);
 				break;
 			case 'V':
-				fprintf(stderr, "%s\n", PACKAGE_VERSION);
+				fprintf(stderr, "%s\n", PROGRAM_VERSION);
 				exit(0);
 				break;
 			default:
diff --git a/ubi-utils/src/ubiupdatevol.c b/ubi-utils/src/ubiupdatevol.c
index 753ad61..011d532 100644
--- a/ubi-utils/src/ubiupdatevol.c
+++ b/ubi-utils/src/ubiupdatevol.c
@@ -154,7 +154,7 @@ parse_opt(int argc, char **argv, struct args *args)
 				break;
 
 			case 'V':
-				fprintf(stderr, "%s\n", PACKAGE_VERSION);
+				fprintf(stderr, "%s\n", PROGRAM_VERSION);
 				exit(0);
 				break;
 
diff --git a/ubi-utils/src/unubi.c b/ubi-utils/src/unubi.c
index f8045d8..0f8945f 100644
--- a/ubi-utils/src/unubi.c
+++ b/ubi-utils/src/unubi.c
@@ -19,6 +19,8 @@
 /*
  * Authors: Frank Haverkamp, haver@vnet.ibm.com
  *	    Drake Dowsett, dowsett@de.ibm.com
+ *
+ * 1.2 Removed argp because we want to use uClibc.
  */
 
 /*
@@ -51,7 +53,7 @@
 
 #define EXEC		"unubi"
 #define CONTACT		"haver@vnet.ibm.com"
-#define VERSION		"0.9"
+#define VERSION		"1.0"
 
 extern char *optarg;
 extern int optind;
-- 
cgit v1.2.3


From d45b87985d5371b2e47458ee0666f7979d5a8c21 Mon Sep 17 00:00:00 2001
From: Josh Boyer <jwboyer@linux.ibm.com>
Date: Tue, 12 Dec 2006 09:22:48 +0100
Subject: [PATCH] Minor ubi utils cleanups

Remove getopt extern declarations

Minor whitespace cleanups

Remove incorrect program names that snuck in during getopt rewrite

Change comments to match reality

Signed-off-by: Josh Boyer <jwboyer@linux.vnet.ibm.com>
Acked-by: Frank Haverkamp <haver@vnet.ibm.com>
---
 ubi-utils/src/bin2nand.c     |  6 ++----
 ubi-utils/src/mkbootenv.c    |  6 ++----
 ubi-utils/src/nand2bin.c     | 14 +++++---------
 ubi-utils/src/pddcustomize.c | 10 ++++------
 ubi-utils/src/pfi2bin.c      |  8 +++-----
 ubi-utils/src/pfiflash.c     |  8 +++-----
 ubi-utils/src/ubigen.c       |  8 +++-----
 ubi-utils/src/ubimirror.c    |  6 ++----
 ubi-utils/src/ubimkvol.c     | 35 ++++++++++++++++++-----------------
 ubi-utils/src/ubirmvol.c     | 25 ++++++++++++-------------
 ubi-utils/src/ubiupdatevol.c |  7 ++-----
 ubi-utils/src/unubi.c        | 19 +++++++------------
 12 files changed, 63 insertions(+), 89 deletions(-)

(limited to 'ubi-utils/src/ubigen.c')

diff --git a/ubi-utils/src/bin2nand.c b/ubi-utils/src/bin2nand.c
index 4bab1ad..20fc90a 100644
--- a/ubi-utils/src/bin2nand.c
+++ b/ubi-utils/src/bin2nand.c
@@ -27,6 +27,7 @@
  * 1.2 Generates separated OOB data, if needed. (oloh)
  * 1.3 Padds data/oob to a given size. (oloh)
  * 1.4 Removed argp because we want to use uClibc.
+ * 1.5 Minor cleanup
  */
 
 #include <unistd.h>
@@ -45,7 +46,7 @@
 #include "config.h"
 #include "nandecc.h"
 
-#define PROGRAM_VERSION "1.4"
+#define PROGRAM_VERSION "1.5"
 
 #define CHECK_ENDP(option, endp) do {			\
 	if (*endp) {					\
@@ -65,9 +66,6 @@ typedef enum action_t {
 #define PADDING		   0 /* 0 means, do not adjust anything */
 #define BUFSIZE		4096
 
-extern char *optarg;
-extern int optind;
-
 static char doc[] = "\nVersion: " PROGRAM_VERSION "\n\tBuilt on "
 	BUILD_CPU" "BUILD_OS" at "__DATE__" "__TIME__"\n"
 	"\n"
diff --git a/ubi-utils/src/mkbootenv.c b/ubi-utils/src/mkbootenv.c
index c05f4e2..4a8cc6a 100644
--- a/ubi-utils/src/mkbootenv.c
+++ b/ubi-utils/src/mkbootenv.c
@@ -20,6 +20,7 @@
  * Create boot-parameter/pdd data from an ASCII-text input file.
  *
  * 1.2 Removed argp because we want to use uClibc.
+ * 1.3 Minor cleanup
  */
 
 #include <stdio.h>
@@ -34,10 +35,7 @@
 #include "bootenv.h"
 #include "error.h"
 
-#define PROGRAM_VERSION "1.2"
-
-extern char *optarg;
-extern int optind;
+#define PROGRAM_VERSION "1.3"
 
 static char doc[] = "\nVersion: " PROGRAM_VERSION "\n\tBuilt on "
 	BUILD_CPU" "BUILD_OS" at "__DATE__" "__TIME__"\n"
diff --git a/ubi-utils/src/nand2bin.c b/ubi-utils/src/nand2bin.c
index 34cce40..636ee6f 100644
--- a/ubi-utils/src/nand2bin.c
+++ b/ubi-utils/src/nand2bin.c
@@ -20,6 +20,7 @@
  * An utility to decompose NAND images and strip OOB off. Not yet finished ...
  *
  * 1.2 Removed argp because we want to use uClibc.
+ * 1.3 Minor cleanup
  */
 
 #include <config.h>
@@ -39,14 +40,11 @@
 #include "config.h"
 #include "nandecc.h"
 
-#define PROGRAM_VERSION "1.2"
+#define PROGRAM_VERSION "1.3"
 
 #define MAXPATH		1024
 #define MIN(x,y)	((x)<(y)?(x):(y))
 
-extern char *optarg;
-extern int optind;
-
 struct args {
 	const char *oob_file;
 	const char *output_file;
@@ -116,14 +114,12 @@ uint32_t str_to_num(char *str)
 /*
  * @brief Parse the arguments passed into the test case.
  *
- * @param key            The parameter.
- * @param arg            Argument passed to parameter.
- * @param state          Location to put information on parameters.
+ * @param argc           The number of arguments
+ * @param argv           The argument list
+ * @param args           Pointer to program args structure
  *
  * @return error
  *
- * Get the `input' argument from `argp_parse', which we know is a
- * pointer to our arguments structure.
  */
 static int
 parse_opt(int argc, char **argv, struct args *args)
diff --git a/ubi-utils/src/pddcustomize.c b/ubi-utils/src/pddcustomize.c
index 5c2a5f0..764f2e7 100644
--- a/ubi-utils/src/pddcustomize.c
+++ b/ubi-utils/src/pddcustomize.c
@@ -25,6 +25,7 @@
  * PDD modification.
  *
  * 1.3 Removed argp because we want to use uClibc.
+ * 1.4 Minor cleanups
  */
 
 #include <stdio.h>
@@ -43,7 +44,7 @@
 #include "libubi.h"
 #include "ubimirror.h"
 
-#define PROGRAM_VERSION "1.3"
+#define PROGRAM_VERSION "1.4"
 
 typedef enum action_t {
 	ACT_NORMAL   = 0,
@@ -60,9 +61,6 @@ typedef enum action_t {
 	args->action = ACT_ARGP_ERR;	\
 } while (0)
 
-extern char *optarg;
-extern int optind;
-
 static char doc[] = "\nVersion: " PROGRAM_VERSION "\n\tBuilt on "
 	BUILD_CPU" "BUILD_OS" at "__DATE__" "__TIME__"\n"
 	"\n"
@@ -81,7 +79,7 @@ static const char *optionsstr =
 "  -V, --version              Print program version\n";
 
 static const char *usage =
-"Usage: pddcustomize.orig [-bclx?V] [-i <input>] [-o <output>] [-s <seqnum>]\n"
+"Usage: pddcustomize [-bclx?V] [-i <input>] [-o <output>] [-s <seqnum>]\n"
 "           [--both] [--copyright] [--input=<input>] [--list]\n"
 "           [--output=<output>] [--side=<seqnum>] [--host] [--help] [--usage]\n"
 "           [--version] [key=value] [...]\n";
@@ -200,7 +198,7 @@ parse_opt(int argc, char **argv, myargs *args)
 				args->file_out = optarg;
 				break;
 			case '?': /* help */
-				err_msg("Usage: pddcustomize.orig [OPTION...] "
+				err_msg("Usage: pddcustomize [OPTION...] "
 					"[key=value] [...]");
 				err_msg("%s", doc);
 				err_msg("%s", optionsstr);
diff --git a/ubi-utils/src/pfi2bin.c b/ubi-utils/src/pfi2bin.c
index 9265fd5..57c4ea5 100644
--- a/ubi-utils/src/pfi2bin.c
+++ b/ubi-utils/src/pfi2bin.c
@@ -24,6 +24,7 @@
  * required to add the right OOB data to the binary image.
  *
  * 1.3 Removed argp because we want to use uClibc.
+ * 1.4 Minor cleanups
  */
 
 #include <stdlib.h>
@@ -44,7 +45,7 @@
 #include "peb.h"
 #include "crc32.h"
 
-#define PROGRAM_VERSION "1.3"
+#define PROGRAM_VERSION "1.4"
 
 #define MAX_FNAME 255
 #define DEFAULT_ERASE_COUNT  0 /* Hmmm.... Perhaps */
@@ -52,9 +53,6 @@
 
 #define MIN(a,b) ((a) < (b) ? (a) : (b))
 
-extern char *optarg;
-extern int optind;
-
 static uint32_t crc32_table[256];
 static char err_buf[ERR_BUF_SIZE];
 
@@ -92,7 +90,7 @@ static const char *optionsstr =
 "  -V, --version              Print program version\n";
 
 static const char *usage =
-"Usage: pfi2bin.orig [-cv?V] [-j pdd-file] [-o filename] [--copyright]\n"
+"Usage: pfi2bin [-cv?V] [-j pdd-file] [-o filename] [--copyright]\n"
 "            [--verbose] [--platform=pdd-file] [--output=filename] [--help]\n"
 "            [--usage] [--version] pfifile\n";
 
diff --git a/ubi-utils/src/pfiflash.c b/ubi-utils/src/pfiflash.c
index 63487b9..0b0da56 100644
--- a/ubi-utils/src/pfiflash.c
+++ b/ubi-utils/src/pfiflash.c
@@ -25,6 +25,7 @@
  * 1.1 fixed output to stderr and stdout in logfile mode.
  * 1.2 updated.
  * 1.3 removed argp parsing to be able to use uClib.
+ * 1.4 Minor cleanups
  */
 
 #include <unistd.h>
@@ -41,10 +42,7 @@
 #include "error.h"
 #include "config.h"
 
-#define PROGRAM_VERSION  "1.3"
-
-extern char *optarg;
-extern int optind;
+#define PROGRAM_VERSION  "1.4"
 
 static char doc[] = "\nVersion: " PROGRAM_VERSION "\n\tBuilt on "
 	BUILD_CPU" "BUILD_OS" at "__DATE__" "__TIME__"\n"
@@ -70,7 +68,7 @@ static const char *optionsstr =
 "  -V, --version              Print program version\n";
 
 static const char *usage =
-"Usage: pfiflash.orig [-cvC?V] [-l <file>] [-p <type>] [-r <dev>] [-s <seqnum>]\n"
+"Usage: pfiflash [-cvC?V] [-l <file>] [-p <type>] [-r <dev>] [-s <seqnum>]\n"
 "            [--copyright] [--logfile=<file>] [--verbose] [--complete]\n"
 "            [--pdd-update=<type>] [--raw-flash=<dev>] [--side=<seqnum>]\n"
 "            [--help] [--usage] [--version] [pfifile]\n";
diff --git a/ubi-utils/src/ubigen.c b/ubi-utils/src/ubigen.c
index 877f469..d99ba2d 100644
--- a/ubi-utils/src/ubigen.c
+++ b/ubi-utils/src/ubigen.c
@@ -22,6 +22,7 @@
  * 1.0 Initial version
  * 1.1 Different CRC32 start value
  * 1.2 Removed argp because we want to use uClibc.
+ * 1.3 Minor cleanups
  */
 
 #include <stdlib.h>
@@ -35,16 +36,13 @@
 #include "ubigen.h"
 #include "config.h"
 
-#define PROGRAM_VERSION "1.2"
+#define PROGRAM_VERSION "1.3"
 
 typedef enum action_t {
 	ACT_NORMAL	     = 0x00000001,
 	ACT_BROKEN_UPDATE    = 0x00000002,
 } action_t;
 
-extern char *optarg;
-extern int optind;
-
 static char doc[] = "\nVersion: " PROGRAM_VERSION "\n\tBuilt on "
 	BUILD_CPU" "BUILD_OS" at "__DATE__" "__TIME__"\n"
 	"\n"
@@ -85,7 +83,7 @@ static const char *optionsstr =
 "  -V, --version              Print program version\n";
 
 static const char *usage =
-"Usage: ubigen.orig [-cdv?V] [-A <num>] [-B <num>] [-E <num>] [-I <num>]\n"
+"Usage: ubigen [-cdv?V] [-A <num>] [-B <num>] [-E <num>] [-I <num>]\n"
 "          [-O <num>] [-T <num>] [-X <num>] [-i <filename>] [-o <filename>]\n"
 "          [-U <leb>] [--copyright] [--debug] [--verbose] [--alignment=<num>]\n"
 "          [--blocksize=<num>] [--erasecount=<num>] [--id=<num>]\n"
diff --git a/ubi-utils/src/ubimirror.c b/ubi-utils/src/ubimirror.c
index 533a0ee..eeedb3a 100644
--- a/ubi-utils/src/ubimirror.c
+++ b/ubi-utils/src/ubimirror.c
@@ -18,6 +18,7 @@
  * Author: Oliver Lohmann
  *
  * 1.2 Removed argp because we want to use uClibc.
+ * 1.3 Minor cleanups
  */
 
 #include <stdio.h>
@@ -34,7 +35,7 @@
 #include "example_ubi.h"
 #include "ubimirror.h"
 
-#define PROGRAM_VERSION "1.2"
+#define PROGRAM_VERSION "1.3"
 
 typedef enum action_t {
 	ACT_NORMAL = 0,
@@ -52,9 +53,6 @@ typedef enum action_t {
 
 #define VOL_ARGS_MAX 2
 
-extern char *optarg;
-extern int optind;
-
 static char doc[] = "\nVersion: " PROGRAM_VERSION "\n\tBuilt on "
 	BUILD_CPU" "BUILD_OS" at "__DATE__" "__TIME__"\n"
 	"\n"
diff --git a/ubi-utils/src/ubimkvol.c b/ubi-utils/src/ubimkvol.c
index e878d70..879dcb6 100644
--- a/ubi-utils/src/ubimkvol.c
+++ b/ubi-utils/src/ubimkvol.c
@@ -27,6 +27,7 @@
  *     the number of bytes.
  * 1.2 Reworked the user-interface to use argp.
  * 1.3 Removed argp because we want to use uClibc.
+ * 1.4 Minor cleanups
  */
 
 #include <stdio.h>
@@ -39,10 +40,7 @@
 #include <config.h>
 #include <libubi.h>
 
-#define PROGRAM_VERSION "1.3"
-
-extern char *optarg;
-extern int optind;
+#define PROGRAM_VERSION "1.4"
 
 /*
  * The variables below	are set by command line arguments.
@@ -114,14 +112,12 @@ struct option long_options[] = {
 /*
  * @brief Parse the arguments passed into the test case.
  *
- * @param key		 The parameter.
- * @param arg		 Argument passed to parameter.
- * @param state		 Location to put information on parameters.
+ * @param argc		 The number of arguments
+ * @param argv		 The list of arguments
+ * @param args		 Pointer to argument structure
  *
  * @return error
  *
- * Get the `input' argument from `argp_parse', which we know is a
- * pointer to our arguments structure.
  */
 static int
 parse_opt(int argc, char **argv, struct args *args)
@@ -142,16 +138,18 @@ parse_opt(int argc, char **argv, struct args *args)
 				else if (!strcmp(optarg, "static"))
 					args->vol_type = UBI_STATIC_VOLUME;
 				else {
-					fprintf(stderr, "Bad volume type: \"%s\"\n",
-							optarg);
+					fprintf(stderr,
+						"Bad volume type: \"%s\"\n",
+						optarg);
 					goto out;
 				}
 				break;
 			case 's':
 				args->bytes = strtoull(optarg, &endp, 0);
 				if (endp == optarg || args->bytes < 0) {
-					fprintf(stderr, "Bad volume size: \"%s\"\n",
-							optarg);
+					fprintf(stderr,
+						"Bad volume size: \"%s\"\n",
+						optarg);
 					goto out;
 				}
 				if (endp != '\0') {
@@ -172,9 +170,11 @@ parse_opt(int argc, char **argv, struct args *args)
 				break;
 			case 'd': /* --devn=<device number> */
 				args->devn = strtoul(optarg, &endp, 0);
-				if (*endp != '\0' || endp == optarg || args->devn < 0) {
-					fprintf(stderr, "Bad UBI device number: "
-							"\"%s\"\n", optarg);
+				if (*endp != '\0' || endp == optarg ||
+					args->devn < 0) {
+					fprintf(stderr,
+						"Bad UBI device number: "
+						"\"%s\"\n", optarg);
 					goto out;
 				}
 				break;
@@ -199,7 +199,8 @@ parse_opt(int argc, char **argv, struct args *args)
 				goto out;
 
 			case '?': /* help */
-				fprintf(stderr, "Usage: ubimkvol [OPTION...]\n");
+				fprintf(stderr,
+					"Usage: ubimkvol [OPTION...]\n");
 				fprintf(stderr, "%s", doc);
 				fprintf(stderr, "%s", optionsstr);
 				fprintf(stderr, "\nReport bugs to %s\n",
diff --git a/ubi-utils/src/ubirmvol.c b/ubi-utils/src/ubirmvol.c
index 04ec085..f458e8a 100644
--- a/ubi-utils/src/ubirmvol.c
+++ b/ubi-utils/src/ubirmvol.c
@@ -24,6 +24,7 @@
  *
  * 1.1 Reworked the userinterface to use argp.
  * 1.2 Removed argp because we want to use uClibc.
+ * 1.3 Minor cleanups
  */
 
 #include <stdio.h>
@@ -36,10 +37,7 @@
 #include <config.h>
 #include <libubi.h>
 
-#define PROGRAM_VERSION "1.2"
-
-extern char *optarg;
-extern int optind;
+#define PROGRAM_VERSION "1.3"
 
 /*
  * The below variables are set by command line options.
@@ -91,14 +89,12 @@ struct option long_options[] = {
 /*
  * @brief Parse the arguments passed into the test case.
  *
- * @param key		 The parameter.
- * @param arg		 Argument passed to parameter.
- * @param state		 Location to put information on parameters.
+ * @param argc		 The number of arguments
+ * @param argv		 The list of arguments
+ * @param args		 Pointer to argument structure
  *
  * @return error
  *
- * Get the `input' argument from `argp_parse', which we know is a
- * pointer to our arguments structure.
  */
 static int
 parse_opt(int argc, char **argv, struct args *args)
@@ -115,9 +111,11 @@ parse_opt(int argc, char **argv, struct args *args)
 		switch (key) {
 			case 'd': /* --devn=<device number> */
 				args->devn = strtoul(optarg, &endp, 0);
-				if (*endp != '\0' || endp == optarg || args->devn < 0) {
-					fprintf(stderr, "Bad UBI device number: "
-							"\"%s\"\n", optarg);
+				if (*endp != '\0' || endp == optarg ||
+					args->devn < 0) {
+					fprintf(stderr,
+						"Bad UBI device number: "
+						"\"%s\"\n", optarg);
 					goto out;
 				}
 				break;
@@ -135,7 +133,8 @@ parse_opt(int argc, char **argv, struct args *args)
 				fprintf(stderr, "Parameter is missing\n");
 				goto out;
 			case '?': /* help */
-				fprintf(stderr, "Usage: ubirmvol [OPTION...]\n");
+				fprintf(stderr,
+					"Usage: ubirmvol [OPTION...]\n");
 				fprintf(stderr, "%s", doc);
 				fprintf(stderr, "%s", optionsstr);
 				fprintf(stderr, "\nReport bugs to %s\n",
diff --git a/ubi-utils/src/ubiupdatevol.c b/ubi-utils/src/ubiupdatevol.c
index 011d532..b3c4bf1 100644
--- a/ubi-utils/src/ubiupdatevol.c
+++ b/ubi-utils/src/ubiupdatevol.c
@@ -24,6 +24,7 @@
  *
  * 1.0 Reworked the userinterface to use argp.
  * 1.1 Removed argp parsing because we want to use uClib.
+ * 1.2 Minor cleanups
  */
 
 #include <errno.h>
@@ -42,16 +43,12 @@
 #include <config.h>
 #include <libubi.h>
 
-#define PROGRAM_VERSION "1.1"
+#define PROGRAM_VERSION "1.2"
 
 #define MAXPATH		1024
 #define BUFSIZE		128 * 1024
 #define MIN(x,y)	((x)<(y)?(x):(y))
 
-/* FIXME is this not covered by including getopt.h? */
-extern char *optarg;
-extern int optind;
-
 struct args {
 	int devn;
 	int vol_id;
diff --git a/ubi-utils/src/unubi.c b/ubi-utils/src/unubi.c
index 0f8945f..cade1e1 100644
--- a/ubi-utils/src/unubi.c
+++ b/ubi-utils/src/unubi.c
@@ -21,6 +21,7 @@
  *	    Drake Dowsett, dowsett@de.ibm.com
  *
  * 1.2 Removed argp because we want to use uClibc.
+ * 1.3 Minor cleanups
  */
 
 /*
@@ -53,10 +54,7 @@
 
 #define EXEC		"unubi"
 #define CONTACT		"haver@vnet.ibm.com"
-#define VERSION		"1.0"
-
-extern char *optarg;
-extern int optind;
+#define VERSION		"1.3"
 
 static char doc[] = "\nVersion: " VERSION "\n\t"
 	BUILD_OS" "BUILD_CPU" at "__DATE__" "__TIME__"\n"
@@ -177,12 +175,6 @@ str_to_num(char *str)
 	return num;
 }
 
-
-/**
- * parses the arguments passed into the program
- * get the input argument from argp_parse, which we know is a
- * pointer to our arguments structure;
- **/
 static int
 parse_opt(int argc, char **argv, struct args *args)
 {
@@ -225,10 +217,13 @@ parse_opt(int argc, char **argv, struct args *args)
 				args->vol_split = SPLIT_RAW;
 				break;
 			case '?': /* help */
-				fprintf(stderr, "Usage: unubi [OPTION...] image-file\n");
+				fprintf(stderr,
+					"Usage: unubi [OPTION...] "
+					"image-file\n");
 				fprintf(stderr, "%s", doc);
 				fprintf(stderr, "%s", optionsstr);
-				fprintf(stderr, "\nReport bugs to %s\n", CONTACT);
+				fprintf(stderr,
+					"\nReport bugs to %s\n", CONTACT);
 				exit(0);
 				break;
 			case 'J':
-- 
cgit v1.2.3