From ef4241da48a95f0a90cbe79f0d0f7d7f2887c40c Mon Sep 17 00:00:00 2001 From: David Oberhollenzer Date: Sun, 10 Nov 2019 15:12:58 +0100 Subject: jittertest: fix error check for open system call The value 0 is a valid file descriptor. The existing error handling would not only treat that as an error, but subsequently leak the file descriptor in the error handling path. Signed-off-by: David Oberhollenzer --- tests/jittertest/JitterTest.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'tests') diff --git a/tests/jittertest/JitterTest.c b/tests/jittertest/JitterTest.c index e109995..797035b 100644 --- a/tests/jittertest/JitterTest.c +++ b/tests/jittertest/JitterTest.c @@ -462,14 +462,14 @@ static void doGrabKProfile(int jitterusec, char *fileName) (void)jitterusec; - if((fdSnapshot = open(fileName, O_WRONLY | O_CREAT, S_IRWXU)) <= 0) + if((fdSnapshot = open(fileName, O_WRONLY | O_CREAT, S_IRWXU)) < 0) { fprintf(stderr, "Could not open file %s.\n", fileName); perror("Error:"); return; } - if((fdProfile = open("/proc/profile", O_RDWR)) <= 0) + if((fdProfile = open("/proc/profile", O_RDWR)) < 0) { fprintf(stderr, "Could not open file /proc/profile. Make sure you booted with profile=2\n"); close(fdSnapshot); @@ -509,7 +509,7 @@ static void clearProfileBuf(void){ char readBuf[10]; - if((fdProfile = open("/proc/profile", O_RDWR)) <= 0) + if((fdProfile = open("/proc/profile", O_RDWR)) < 0) { fprintf(stderr, "Could not open file /proc/profile. Make sure you booted with profile=2\n"); return; -- cgit v1.2.3