From 49e6cb7b62c5d7cd5c0a5084c91a84cd9fa8e0fe Mon Sep 17 00:00:00 2001 From: Xiaolei Li Date: Mon, 29 Apr 2019 11:28:34 +0800 Subject: mtd-tests: nandbiterrs: Fix issue that just insert error at bit 7 The function insert_biterror should be designed to insert error at the first '1' bit starting at offset byte. But now, only bit 7 of each byte is checked, because checking mask is always 0x80. So, do right shift for checking mask after each checking to check the whole 8 bits of each bytes. Signed-off-by: Xiaolei Li Signed-off-by: David Oberhollenzer --- tests/mtd-tests/nandbiterrs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'tests') diff --git a/tests/mtd-tests/nandbiterrs.c b/tests/mtd-tests/nandbiterrs.c index 24a6c03..f583c14 100644 --- a/tests/mtd-tests/nandbiterrs.c +++ b/tests/mtd-tests/nandbiterrs.c @@ -333,7 +333,7 @@ static int insert_biterror(void) int bit, mask, byte; for (byte = 0; byte < pagesize; ++byte) { - for (bit = 7, mask = 0x80; bit >= 0; bit--, mask>>=0) { + for (bit = 7, mask = 0x80; bit >= 0; bit--, mask >>= 1) { if (wbuffer[byte] & mask) { wbuffer[byte] &= ~mask; printf("Inserted biterror @ %u/%u\n", byte, bit); -- cgit v1.2.3