From 0555cb2ea9bdc8e210e87e009154954a9bbc3a55 Mon Sep 17 00:00:00 2001 From: David Oberhollenzer Date: Thu, 2 Nov 2017 01:10:11 +0100 Subject: jittertest: Use the appropriate versions of abs() When passing a long argument, actually use labs(). The other case of passing a float to "int abs(int)" and casting the result to an int doesn't really make sense. Pull the cast inside the abs(). Signed-off-by: David Oberhollenzer --- tests/jittertest/JitterTest.c | 6 +++--- tests/jittertest/plotJittervsFill.c | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) (limited to 'tests') diff --git a/tests/jittertest/JitterTest.c b/tests/jittertest/JitterTest.c index 4627fb0..e109995 100644 --- a/tests/jittertest/JitterTest.c +++ b/tests/jittertest/JitterTest.c @@ -591,12 +591,12 @@ void AlarmHandler( /* Store some historical #'s */ - if(abs(timeDiffusec) > LastMaxDiff) + if(labs(timeDiffusec) > LastMaxDiff) { - LastMaxDiff = abs(timeDiffusec); + LastMaxDiff = labs(timeDiffusec); sprintf(&tmpBuf[strlen(tmpBuf)],"!"); - if((GrabKProfile == TRUE) && (ProfileTriggerMSecs < (abs(timeDiffusec)/1000))) + if((GrabKProfile == TRUE) && (ProfileTriggerMSecs < (labs(timeDiffusec)/1000))) { sprintf(profileFileName, "JitterTest.profilesnap-%i", profileFileNo); diff --git a/tests/jittertest/plotJittervsFill.c b/tests/jittertest/plotJittervsFill.c index 8d71a33..03929a9 100644 --- a/tests/jittertest/plotJittervsFill.c +++ b/tests/jittertest/plotJittervsFill.c @@ -267,7 +267,7 @@ int main( } /* Is the jitter value > threshold value? */ - if(abs(jitter_ms) > JitterThreshold_ms) + if(abs((int)jitter_ms) > JitterThreshold_ms) { /* Found a jitter line that matches our crietrion. Now set flag to be on the look out for the next @@ -276,7 +276,7 @@ int main( if(saveJitterCnt < MAX_SAVE_BUFFER) { - saveJitter[saveJitterCnt] = (int)abs(jitter_ms); /* why keep the (ms) jitter in float */ + saveJitter[saveJitterCnt] = abs((int)jitter_ms); /* why keep the (ms) jitter in float */ dataLineNo[saveJitterCnt] = lineNo; saveJitterCnt++; lookFor_df = TRUE; -- cgit v1.2.3