From a70811466de2c4c0c3a538e5e04a4dd1a8fbcc03 Mon Sep 17 00:00:00 2001 From: Andy Shevchenko Date: Tue, 5 Apr 2011 17:32:29 +0300 Subject: tests: jittertest: fix set of compiler warnings - time() was used without prototype. - the return value of read() and write() wasn't checked - classificator in printf() was wrong for argument of size_t type Don't continue to read the /proc/profile in case when write was failed. Signed-off-by: Andy Shevchenko Signed-off-by: Artem Bityutskiy --- tests/jittertest/JitterTest.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) (limited to 'tests/jittertest') diff --git a/tests/jittertest/JitterTest.c b/tests/jittertest/JitterTest.c index fcf8e0d..76371e8 100644 --- a/tests/jittertest/JitterTest.c +++ b/tests/jittertest/JitterTest.c @@ -82,6 +82,7 @@ #include /* strcpy, strcmp */ #include /* exit, atol, atoi */ #include /* setitimer, settimeofday, gettimeofday */ +#include /* time */ #include /* signal */ #include /* sched_setscheduler, sched_get_priority_min,*/ /* sched_get_priority_max */ @@ -475,7 +476,11 @@ void doGrabKProfile(int jitterusec, char *fileName) while((readBytes = read(fdProfile, readBuf, sizeof(readBuf))) > 0) { - write(fdSnapshot, readBuf, readBytes); + int writeBytes = write(fdSnapshot, readBuf, readBytes); + if (writeBytes != readBytes) { + perror("write error"); + break; + } } close(fdSnapshot); @@ -650,7 +655,9 @@ void AlarmHandler( if(DoRead) { - read(Fd2, tmpBuf, 1); + cntr = read(Fd2, tmpBuf, 1); + if (cntr < 0) + perror("read error"); lseek(Fd2, 0, SEEK_SET); /* back to start */ } @@ -1032,7 +1039,7 @@ int Write(int fd, void *buf, size_t bytes, int lineNo) if(err < bytes) { - printf("Write Error at line %i! Wanted to write %i bytes, but wrote only %i bytes.\n", + printf("Write Error at line %i! Wanted to write %zu bytes, but wrote only %i bytes.\n", lineNo, bytes, err); perror("Write did not complete. Error. Bye:"); /* show error from errno. */ exit(1); -- cgit v1.2.3