From 7dd42c510dc8ab10f52dcc2d20dc8af412be0744 Mon Sep 17 00:00:00 2001 From: David Oberhollenzer Date: Tue, 19 Jul 2016 15:06:58 +0200 Subject: Unify version string printing When a program does sophisticated enough command line processing (i.e. getopt), make sure it responds to -V and --version. When a program prints a version string, make sure it uses the common_print_version macro to print out its name, that it is part of mtd-utils and the mtd-utils version from the build system in a fashion similar to common program packages like the GNU coreutils. When a program responds to -V/--version or -h/--help, make sure it reports success exit status. Signed-off-by: David Oberhollenzer Signed-off-by: Richard Weinberger --- tests/fs-tests/integrity/integck.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) (limited to 'tests/fs-tests') diff --git a/tests/fs-tests/integrity/integck.c b/tests/fs-tests/integrity/integck.c index c6319fb..67384fa 100644 --- a/tests/fs-tests/integrity/integck.c +++ b/tests/fs-tests/integrity/integck.c @@ -37,7 +37,6 @@ #include #include -#define PROGRAM_VERSION "1.1" #define PROGRAM_NAME "integck" #include "common.h" #include "libubi.h" @@ -2992,7 +2991,7 @@ static void get_tested_fs_info(void) pid, fsinfo.fstype, fsinfo.mount_point); } -static const char doc[] = PROGRAM_NAME " version " PROGRAM_VERSION +static const char doc[] = PROGRAM_NAME " version " VERSION " - a stress test which checks the file-system integrity.\n" "\n" "The test creates a directory named \"integck_test_dir_\", where where\n" @@ -3077,7 +3076,7 @@ static int parse_opts(int argc, char * const argv[]) args.verbose = 1; break; case 'V': - fprintf(stderr, "%s\n", PROGRAM_VERSION); + common_print_version(); exit(EXIT_SUCCESS); case 'h': -- cgit v1.2.3