From 475bf707b958f37844534b7b45c905521c7401a2 Mon Sep 17 00:00:00 2001 From: David Oberhollenzer <david.oberhollenzer@sigma-star.at> Date: Thu, 21 Sep 2017 11:15:32 +0200 Subject: Mark or fix switch cases that fall through Now that C++17 introduced a special fallthrough keyword for explicitly tagging switch cases that are supposed to fall through, newer gcc versions also implement a feature request from 2002 to warn about maybe unwanted fall-throughs in switch cases in other languages (like C). For C code, we can either add a gcc specific attribute at the end of the switch case, or use a special comment that gcc checks for, indicating that the fall-through behaviour is indeed intended. This patch adds a "/* fall-through */" comment at the end of various case blocks to silence gcc warnings and in some cases a break, where fall-through was probably not intended. Signed-off-by: David Oberhollenzer <david.oberhollenzer@sigma-star.at> --- nand-utils/nanddump.c | 1 + 1 file changed, 1 insertion(+) (limited to 'nand-utils') diff --git a/nand-utils/nanddump.c b/nand-utils/nanddump.c index bebb48e..2f167bb 100644 --- a/nand-utils/nanddump.c +++ b/nand-utils/nanddump.c @@ -180,6 +180,7 @@ static void process_options(int argc, char * const argv[]) break; case 'c': canonical = true; + /* fall-through */ case 'p': pretty_print = true; break; -- cgit v1.2.3