From cb2fcfc0a1da3cfac9094abf1d11c23653937395 Mon Sep 17 00:00:00 2001 From: David Oberhollenzer Date: Thu, 21 Sep 2017 13:36:42 +0200 Subject: Add no-return attribute to usage() style functions A common pattern in command line processing is having a usage() function that prints out how to use the command line options and then terminates. The function is typically used inside a switch block for command line options like `-h' or unknown options. In a lot of places, the break keyword is omitted, because the function exits anyway. However, this triggers gcc warnings about implicit fall-through. Rather than adding a phony "/* fall-through */" this patch flags the usage() style function with a gcc attribute, indicating that they do not return and removes further superfluous break statements. Signed-off-by: David Oberhollenzer --- misc-utils/flashcp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'misc-utils/flashcp.c') diff --git a/misc-utils/flashcp.c b/misc-utils/flashcp.c index a35e6fc..0718733 100644 --- a/misc-utils/flashcp.c +++ b/misc-utils/flashcp.c @@ -81,7 +81,7 @@ static void log_printf (int level,const char *fmt, ...) fflush (fp); } -static void showusage(bool error) +static NORETURN void showusage(bool error) { int level = error ? LOG_ERROR : LOG_NORMAL; -- cgit v1.2.3