From 772469f83a54e4bc077880212e37b0e7b9ba85ac Mon Sep 17 00:00:00 2001 From: Marcus Prebble Date: Tue, 6 Oct 2015 14:13:23 +0200 Subject: libmtd: mtd_read: Take the buffer offset into account when reading Assuming the read() call does not return zero and the result is less than len, the current implementation will overwrite the data already read in buf which doesn't seem correct. With this patch, subsequent calls to read() within the loop will now no longer overwrite the existing contents of buf. Signed-off-by: Marcus Prebble Signed-off-by: Brian Norris --- lib/libmtd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'lib') diff --git a/lib/libmtd.c b/lib/libmtd.c index 60b4782..bf6d71f 100644 --- a/lib/libmtd.c +++ b/lib/libmtd.c @@ -1072,10 +1072,10 @@ int mtd_read(const struct mtd_dev_info *mtd, int fd, int eb, int offs, mtd->mtd_num, seek); while (rd < len) { - ret = read(fd, buf, len); + ret = read(fd, buf + rd, len - rd); if (ret < 0) return sys_errmsg("cannot read %d bytes from mtd%d (eraseblock %d, offset %d)", - len, mtd->mtd_num, eb, offs); + len - rd, mtd->mtd_num, eb, offs + rd); rd += ret; } -- cgit v1.2.3