From 514063a6d7a628e358894b6a6a6cb089c264fc09 Mon Sep 17 00:00:00 2001 From: Aviv Daum Date: Thu, 19 Mar 2026 00:53:32 +0200 Subject: mtd-utils: tests: jittertest: reject overlong file names plotJittervsFill copies the -f argument into a 250-byte buffer with strncpy(..., sizeof(LogFile)). A 250-byte file name leaves the buffer unterminated, and the subsequent fopen() reads past the end of LogFile. JitterTest uses the same fixed-size file name pattern for -r, while -c still silently truncates overlong names and -f already rejects them. Validate jittertest file name arguments before copying them so these options all reject overlong input instead of truncating it or reading past the end of fixed-size buffers. Add a shell regression test that exercises the accepted and rejected boundary lengths for plotJittervsFill and JitterTest during make check. Signed-off-by: Aviv Daum Signed-off-by: David Oberhollenzer --- Makefile.am | 3 +++ 1 file changed, 3 insertions(+) (limited to 'Makefile.am') diff --git a/Makefile.am b/Makefile.am index c756127..ba54acc 100644 --- a/Makefile.am +++ b/Makefile.am @@ -42,6 +42,9 @@ test_SCRIPTS = test_DATA = TESTS = +TEST_EXTENSIONS = .sh +SH_LOG_COMPILER = $(SHELL) +AM_TESTS_ENVIRONMENT = TESTBINDIR='$(abs_top_builddir)'; export TESTBINDIR; EXTRA_DIST = COPYING CHANGELOG.md README.txt include lib/Makemodule.am -- cgit v1.2.3