From b0b1bc51496b7c328fcda3e6164292fa0d1dbc18 Mon Sep 17 00:00:00 2001 From: Harpreet Eli Sangha Date: Tue, 27 Jun 2017 13:52:26 -0700 Subject: mtd-utils: tests: Fix nandbiterrs Failure Check After a page read, the old failure statistics are compared against the new failure statistics before the new values are actually read. Signed-off-by: Harpreet "Eli" Sangha Signed-off-by: David Oberhollenzer --- tests/mtd-tests/nandbiterrs.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/mtd-tests/nandbiterrs.c b/tests/mtd-tests/nandbiterrs.c index 6acbfee..de9d0dd 100644 --- a/tests/mtd-tests/nandbiterrs.c +++ b/tests/mtd-tests/nandbiterrs.c @@ -268,15 +268,15 @@ static int read_page(void) return -1; } + if (ioctl(fd, ECCGETSTATS, &new) != 0) + goto failstats; + if (new.failed > old.failed) { fprintf(stderr, "Failed to recover %d bitflips\n", new.failed - old.failed); return -1; } - if (ioctl(fd, ECCGETSTATS, &new) != 0) - goto failstats; - return new.corrected - old.corrected; failstats: perror("ECCGETSTATS"); -- cgit v1.2.3