From 36d8de81049c9c908740b690c664b5bd3703ccd6 Mon Sep 17 00:00:00 2001 From: Andy Shevchenko Date: Mon, 19 Sep 2011 14:25:24 +0300 Subject: jffs2reader: use major() and minor() helpers There are major() and minor() helpers in the standard library. We can use them. Signed-off-by: Andy Shevchenko Signed-off-by: Artem Bityutskiy --- jffs2reader.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/jffs2reader.c b/jffs2reader.c index 501b6bf..5231ff0 100644 --- a/jffs2reader.c +++ b/jffs2reader.c @@ -81,13 +81,6 @@ BUGS: #define SCRATCH_SIZE (5*1024*1024) -#ifndef MAJOR -/* FIXME: I am using illicit insider knowledge of - * kernel major/minor representation... */ -#define MAJOR(dev) (((dev)>>8)&0xff) -#define MINOR(dev) ((dev)&0xff) -#endif - /* macro to avoid "lvalue required as left operand of assignment" error */ #define ADD_BYTES(p, n) ((p) = (typeof(p))((char *)(p) + (n))) @@ -362,7 +355,7 @@ void printdir(char *o, size_t size, struct dir *d, const char *path, int recurse dev_t rdev; size_t devsize; putblock((char*)&rdev, sizeof(rdev), &devsize, ri); - printf("%4d, %3d ", (int)MAJOR(rdev), (int)MINOR(rdev)); + printf("%4d, %3d ", major(rdev), minor(rdev)); } else { printf("%9ld ", (long)je32_to_cpu(ri->dsize)); } -- cgit v1.2.3