From 1145ef7ee979dde2d611e09d00fc6ff0090dcc9d Mon Sep 17 00:00:00 2001 From: Uwe Kleine-König Date: Thu, 28 Feb 2013 10:42:26 +0100 Subject: flash_otp_write: fix a buffer overflow on NAND with write size > 2048 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit I'm not aware of any chip having a write size bigger than 2048 today. Still checking for that instead of a sleeping problem to bite us maybe in a few years is easy. Signed-off-by: Uwe Kleine-König Signed-off-by: Artem Bityutskiy --- flash_otp_write.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/flash_otp_write.c b/flash_otp_write.c index 3515eee..eaca5e1 100644 --- a/flash_otp_write.c +++ b/flash_otp_write.c @@ -83,6 +83,12 @@ int main(int argc,char *argv[]) else len = 256; + if (len > sizeof(buf)) { + printf("huh, writesize (%d) bigger than buffer (%zu)\n", + len, sizeof(buf)); + return ENOMEM; + } + wrote = 0; while ((size = xread(0, buf, len))) { if (size < 0) { -- cgit v1.2.3